<div dir="ltr"><div class="gmail_default" style="font-family:courier new,monospace;font-size:large"><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 14 May 2014 22:21, Wojciech Kosowicz <span dir="ltr"><<a href="mailto:pcellix@gmail.com" target="_blank">pcellix@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117966/" target="_blank">https://git.reviewboard.kde.org/r/117966/</a>
</td>
</tr>
</tbody></table>
<br>
</div><div class=""><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On May 14th, 2014, 8:15 p.m. UTC, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I am using:
./sql_keywords.sh /tmp/sqlite-src-3080403.zip /tmp/mysql-5.6.17.tar.gz /tmp/postgresql-9.3.4.tar.gz
Please try this case.
Matching does not work because the code such as [[ ! $sqlArchive == sqlite*.zip ]] expects filename without a path. Better do not expect people to save the archives in source dir calligra/kexi/tools/sql_keywords/.</pre>
</blockquote>
</blockquote>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">what do you think about? [[ ! $sqlArchive == *sqlite*.zip ]] i guess it should work for all cases</pre>
<span class="HOEnZb"><font color="#888888">
<br></font></span></div></div></blockquote><div><br><div class="gmail_default" style="font-family:courier new,monospace;font-size:large;display:inline">Yes, should work.<br></div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class="HOEnZb"><font color="#888888">
<p>- Wojciech</p></font></span><div class="">
<br>
<p>On May 14th, 2014, 7:45 p.m. UTC, Wojciech Kosowicz wrote:</p>
<table style="background-image:url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');background-repeat:repeat-x;border:1px black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Wojciech Kosowicz.</div>
<p style="color:grey"><i>Updated May 14, 2014, 7:45 p.m.</i></p>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
calligra
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This patch contains changes for sql_keywords.sh script that generates source files that contains keywords for specific database technology (kexisql, sqlite, postrsql, mysql).
I did my best still I think functions getPostgreSQLKeywords and getSQLiteKeywords can be done in a better (old mechanism did not work but I think there can be better ways than what I came up with.
Every suggestions are welcome
TODO:
updating comments as some functions changed names/attributes
</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">4 files that contained keywords are generated and they do contain them</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>kexi/tools/sql_keywords/sql_keywords.sh <span style="color:grey">(6bcc5de)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117966/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div>
</div>
</blockquote></div><br><br clear="all"><br>-- <br>regards / pozdrawiam, Jaroslaw Staniek<br> Kexi & Calligra & KDE | <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a> | <a href="http://kde.org" target="_blank">http://kde.org</a><br>
Qt for Tizen | <a href="http://qt-project.org/wiki/Tizen" target="_blank">http://qt-project.org/wiki/Tizen</a><br> Qt Certified Specialist | <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a><br>
</div></div>