Review Request 117966: Updated script for generating databases keywords in Kexi

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117966/#review57838
-----------------------------------------------------------


1. I thought we can use newer source code, Mysql 4 and pgsql 7.4 isn't particularly new. So I started:
% ./sql_keywords.sh /tmp/mysql-5.6.17.tar.gz  /tmp/postgresql-9.3.4.tar.gz /tmp/sqlite-src-3080403.zip 

and this is the output:
-----
Writing keywords in calligra/kexi/kexidb/parser/sqlscanner.l
 * and calligra/kexi/tools/sql_keywords/kexi_reserved to keywords.cpp
-----

2. If the script stops with error, kexi.all stays in the source code dir; it would be good to remove it



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment40257>

    How about changing to this? (please test these versions) ->
    
    Put three DB source archives in the current directory in proper order, e.g.:
    * mysql-5.6.17.tar.gz from http://dev.mysql.com/downloads/mysql/
    * postgresql-9.3.4.tar.gz from http://www.postgresql.org/ftp/source/
    * sqlite-src-3080403.zip from http://www.sqlite.org/download.html
    


- Jarosław Staniek


On May 10, 2014, 6:17 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117966/
> -----------------------------------------------------------
> 
> (Updated May 10, 2014, 6:17 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch contains changes for sql_keywords.sh script that generates source files that contains keywords for specific database technology (kexisql, sqlite, postrsql, mysql). 
> I did my best still I think functions getPostgreSQLKeywords and getSQLiteKeywords can be done in a better (old mechanism did not work but I think there can be better ways than what I came up with.
> Every suggestions are welcome
> TODO:
> updating comments as some functions changed names/attributes
> 
> 
> Diffs
> -----
> 
>   kexi/tools/sql_keywords/sql_keywords.sh 6bcc5de 
> 
> Diff: https://git.reviewboard.kde.org/r/117966/diff/
> 
> 
> Testing
> -------
> 
> 4 files that contained keywords are generated and they do contain them
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140513/36ddcc71/attachment.htm>