<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117966/">https://git.reviewboard.kde.org/r/117966/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. I thought we can use newer source code, Mysql 4 and pgsql 7.4 isn't particularly new. So I started:
% ./sql_keywords.sh /tmp/mysql-5.6.17.tar.gz /tmp/postgresql-9.3.4.tar.gz /tmp/sqlite-src-3080403.zip
and this is the output:
-----
Writing keywords in calligra/kexi/kexidb/parser/sqlscanner.l
* and calligra/kexi/tools/sql_keywords/kexi_reserved to keywords.cpp
-----
2. If the script stops with error, kexi.all stays in the source code dir; it would be good to remove it
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/117966/diff/4-5/?file=272017#file272017line17" style="color: black; font-weight: bold; text-decoration: underline;">kexi/tools/sql_keywords/sql_keywords.sh</a>
<span style="font-weight: normal;">
(Diff revisions 4 - 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># postgresql-base-7.4.6.tar.gz) in the current directory</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c"># postgresql-base-7.4.6.tar.gz<span class="hl">, sqlite-src-3080403.zip</span>) in the current directory</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How about changing to this? (please test these versions) ->
Put three DB source archives in the current directory in proper order, e.g.:
* mysql-5.6.17.tar.gz from http://dev.mysql.com/downloads/mysql/
* postgresql-9.3.4.tar.gz from http://www.postgresql.org/ftp/source/
* sqlite-src-3080403.zip from http://www.sqlite.org/download.html
</pre>
</div>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On May 10th, 2014, 6:17 p.m. UTC, Wojciech Kosowicz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Wojciech Kosowicz.</div>
<p style="color: grey;"><i>Updated May 10, 2014, 6:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch contains changes for sql_keywords.sh script that generates source files that contains keywords for specific database technology (kexisql, sqlite, postrsql, mysql).
I did my best still I think functions getPostgreSQLKeywords and getSQLiteKeywords can be done in a better (old mechanism did not work but I think there can be better ways than what I came up with.
Every suggestions are welcome
TODO:
updating comments as some functions changed names/attributes
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">4 files that contained keywords are generated and they do contain them</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/tools/sql_keywords/sql_keywords.sh <span style="color: grey">(6bcc5de)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117966/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>