Review Request 118056: Removing non-direct children of kexiwindow from to be deleted list
Wojciech Kosowicz
pcellix at gmail.com
Thu May 8 21:34:25 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118056/
-----------------------------------------------------------
(Updated May 8, 2014, 8:34 p.m.)
Review request for Calligra and Jarosław Staniek.
Changes
-------
this patch simplifies the activity of getting kexiview that is related directly to kexiwindow. It was created as a result of collaboration with Adam Pigg
@Adam thanks for help on this :)
Bugs: 334234
http://bugs.kde.org/show_bug.cgi?id=334234
Repository: calligra
Description
-------
The findChildren method returned all the children even those non-direct When deleting view it propagates from parent to children. Therefore situation occured when view was first indirectly deleted and them directly. This checks for the non-direct childs and deletes from the list
Diffs (updated)
-----
kexi/core/KexiWindow.cpp bcb552a
Diff: https://git.reviewboard.kde.org/r/118056/diff/
Testing
-------
Query designer should no longer crash
File Attachments
----------------
0001-Removing-non-direct-children-of-kexiwindow-from-to-b.patch
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/e32e0428-6e85-4898-a425-ba12a1e4c7fc__0001-Removing-non-direct-children-of-kexiwindow-from-to-b.patch
Thanks,
Wojciech Kosowicz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140508/040f8fcc/attachment.htm>
More information about the calligra-devel
mailing list