Review Request 118056: Removing non-direct children of kexiwindow from to be deleted list

[Adam Pigg]

> On May 8, 2014, 7:10 p.m., Adam Pigg wrote:
> > kexi/core/KexiWindow.cpp, line 318
> > <https://git.reviewboard.kde.org/r/118056/diff/1/?file=272042#file272042line318>
> >
> >     Maybe instead of to multiple iterations, you could just check if the view has the window as its parent?
> 
> Wojciech Kosowicz wrote:
>     I tried i did not work. Window is not the parent of these elements. It goes way up to classes for example: QSplitter, KexiSectionHeader
>

have a look at d->stack eg
if (view->parent() == d->stack) ;)


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118056/#review57603
-----------------------------------------------------------


On May 8, 2014, 6:34 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118056/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 6:34 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Bugs: 334234
>     http://bugs.kde.org/show_bug.cgi?id=334234
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The findChildren method returned all the children even those non-direct When deleting view it propagates from parent to children. Therefore situation occured when view was first indirectly deleted and them directly. This checks for the non-direct childs and deletes from the list
> 
> 
> Diffs
> -----
> 
>   kexi/core/KexiWindow.cpp bcb552a 
> 
> Diff: https://git.reviewboard.kde.org/r/118056/diff/
> 
> 
> Testing
> -------
> 
> Query designer should no longer crash
> 
> 
> File Attachments
> ----------------
> 
> 0001-Removing-non-direct-children-of-kexiwindow-from-to-b.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/e32e0428-6e85-4898-a425-ba12a1e4c7fc__0001-Removing-non-direct-children-of-kexiwindow-from-to-b.patch
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140508/8bb506db/attachment.htm>