Review Request 116949: close all tabs command added

[Jarosław Staniek]

> On March 21, 2014, 9:09 p.m., Radosław Wicik wrote:
> > kexi/main/KexiMainWindow.cpp, line 216
> > <https://git.reviewboard.kde.org/r/116949/diff/1/?file=255904#file255904line216>
> >
> >     Maby you should use qobject_cast instead of dynamic_cast?

Cannot be used because KexiMainWindowIface::global() isn't a QObject*.


> On March 21, 2014, 9:09 p.m., Radosław Wicik wrote:
> > kexi/main/KexiMainWindow.cpp, line 210
> > <https://git.reviewboard.kde.org/r/116949/diff/1/?file=255904#file255904line210>
> >
> >     Try to move this function to KexiMainWindow, it should be few times simpler then current implementation.
> >     We just need a button in KexiMainWindowTabWidget, but KexiMainWindow holds all tabs and this is a place where all of them should be closed.

@Radek no, no, KexiMainWindowTabWidget has closeTab() already and it works well.  KexiMainWindowTabWidget holds all tabs.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116949/#review53717
-----------------------------------------------------------


On March 21, 2014, 1:37 p.m., Vishwa Modi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116949/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 1:37 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> new KAction m_closeAction2 is added and closeAllTabs() function is added.
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.h 3d76bb2 
>   kexi/main/KexiMainWindow.cpp e916281 
> 
> Diff: https://git.reviewboard.kde.org/r/116949/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishwa Modi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140321/4339555a/attachment.htm>