Review Request 116949: close all tabs command added

[Radosław Wicik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116949/#review53717
-----------------------------------------------------------



kexi/main/KexiMainWindow.h
<https://git.reviewboard.kde.org/r/116949/#comment37671>

    You should use more descriptive name like m_closeAllTabsAction, your name suggests it some different type of Action.



kexi/main/KexiMainWindow.cpp
<https://git.reviewboard.kde.org/r/116949/#comment37666>

    Possible bug: Are You sure you want to change text in m_closeAction and not in m_closeAction2?
    



kexi/main/KexiMainWindow.cpp
<https://git.reviewboard.kde.org/r/116949/#comment37667>

    Possible bug: Are You sure you would like to change m_closeAction and not m_closeAction2
    



kexi/main/KexiMainWindow.cpp
<https://git.reviewboard.kde.org/r/116949/#comment37673>

    Try to move this function to KexiMainWindow, it should be few times simpler then current implementation.
    We just need a button in KexiMainWindowTabWidget, but KexiMainWindow holds all tabs and this is a place where all of them should be closed.



kexi/main/KexiMainWindow.cpp
<https://git.reviewboard.kde.org/r/116949/#comment37665>

    Maby you should use qobject_cast instead of dynamic_cast?


- Radosław Wicik


On March 21, 2014, 2:37 p.m., Vishwa Modi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116949/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 2:37 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> new KAction m_closeAction2 is added and closeAllTabs() function is added.
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.h 3d76bb2 
>   kexi/main/KexiMainWindow.cpp e916281 
> 
> Diff: https://git.reviewboard.kde.org/r/116949/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishwa Modi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140321/2e313b05/attachment.htm>