Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

[Inge Wallin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118984/#review61158
-----------------------------------------------------------

Ship it!


In general looks good.  But shouldn't the same idea be used in the other apps too?


sheets/DocBase.cpp
<https://git.reviewboard.kde.org/r/118984/#comment42594>

    While I like this assert here, shouldn't it be in KoDocument where it is shared by all applications?



sheets/part/Doc.cpp
<https://git.reviewboard.kde.org/r/118984/#comment42595>

    Not strictly necessary since DocBase::DocBase already has the same Q_ASSERT. If you want to keep it, I'm fine with that too.


- Inge Wallin


On June 27, 2014, 10:25 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118984/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 10:25 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> KoPart argument of KoDocument and descendants should not be optional
> 
> Currently KoPart is required, there is even assertion for, so express this in the API.
> Current API apparently caused one crash (in spreadsheet plugin of Kexi).
> 
> Also put 2 more assertions as early as possible.
> 
> Finally, fixed outdated docs.
> 
> 
> Diffs
> -----
> 
>   sheets/DocBase.h 946e9cd9bdbf414430bd7914bc6bb5bf3e57c3df 
>   sheets/DocBase.cpp b01a2004c15d2a03201e527af3ac3255f8c75646 
>   sheets/part/Doc.h bf8341cafd0f6f79668870043af1169ce76df0ca 
>   sheets/part/Doc.cpp 44fd7ab5e237676296a28590e938a01669f0bb86 
> 
> Diff: https://git.reviewboard.kde.org/r/118984/diff/
> 
> 
> Testing
> -------
> 
> Builds, nobody is used the argument-less constructor (after https://git.reviewboard.kde.org/r/118983/ is pushed)
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140629/8516cf5b/attachment.htm>