Review Request 118984: KoPart argument of KoDocument and descendants should not be optional

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118984/
-----------------------------------------------------------

Review request for Calligra and Boudewijn Rempt.


Repository: calligra


Description
-------

KoPart argument of KoDocument and descendants should not be optional

Currently KoPart is required, there is even assertion for, so express this in the API.
Current API apparently caused one crash (in spreadsheet plugin of Kexi).

Also put 2 more assertions as early as possible.

Finally, fixed outdated docs.


Diffs
-----

  sheets/DocBase.h 946e9cd9bdbf414430bd7914bc6bb5bf3e57c3df 
  sheets/DocBase.cpp b01a2004c15d2a03201e527af3ac3255f8c75646 
  sheets/part/Doc.h bf8341cafd0f6f79668870043af1169ce76df0ca 
  sheets/part/Doc.cpp 44fd7ab5e237676296a28590e938a01669f0bb86 

Diff: https://git.reviewboard.kde.org/r/118984/diff/


Testing
-------

Builds, nobody is used the argument-less constructor (after https://git.reviewboard.kde.org/r/118983/ is pushed)


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140627/de6c1848/attachment.htm>