Review Request 118736: cmake files for odb reader and add odb in a drop down

[harshita mistry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118736/
-----------------------------------------------------------

(Updated June 28, 2014, 5:40 a.m.)


Review request for Calligra and Jarosław Staniek.


Changes
-------

-fixed: extra public: not needed
-fixed: We need to uncomment this so the plugin gets exported.
-fixed: Better to check ret != JNI_OK
-fixed: Convention: \n's not needed
-fixed: JNIEnv *env needs to be used in other methods so let's put it somewhere else.
-fixed: coding style
-fixed: DestroyJavaVM() 


Repository: calligra


Description
-------

cmake files that compiles odb reader c++ program and desktop file that adds odb as an import option in the import table drop down menu.


Diffs (updated)
-----

  kexi/migration/CMakeLists.txt 2478b10 
  CMakeLists.txt c3bb9fc 
  kexi/migration/odb/CMakeLists.txt PRE-CREATION 
  kexi/migration/odb/keximigrate_odb.desktop PRE-CREATION 
  kexi/migration/odb/odbmigrate.h PRE-CREATION 
  kexi/migration/odb/odbmigrate.cpp PRE-CREATION 
  kexi/migration/odb/reader/CMakeLists.txt PRE-CREATION 
  kexi/migration/odb/reader/OdbReader.java PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/118736/diff/


Testing
-------


Thanks,

harshita mistry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140628/d5254f98/attachment.htm>