<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118736/">https://git.reviewboard.kde.org/r/118736/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By harshita mistry.</div>
<p style="color: grey;"><i>Updated June 28, 2014, 5:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">-fixed: extra public: not needed
-fixed: We need to uncomment this so the plugin gets exported.
-fixed: Better to check ret != JNI_OK
-fixed: Convention: \n's not needed
-fixed: JNIEnv *env needs to be used in other methods so let's put it somewhere else.
-fixed: coding style
-fixed: DestroyJavaVM() </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cmake files that compiles odb reader c++ program and desktop file that adds odb as an import option in the import table drop down menu.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/migration/CMakeLists.txt <span style="color: grey">(2478b10)</span></li>
<li>CMakeLists.txt <span style="color: grey">(c3bb9fc)</span></li>
<li>kexi/migration/odb/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/migration/odb/keximigrate_odb.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/migration/odb/odbmigrate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/migration/odb/odbmigrate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/migration/odb/reader/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>kexi/migration/odb/reader/OdbReader.java <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118736/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>