Review Request 118517: New brush stabilizer

[Juan Luis Boya García]

> On June 4, 2014, 9:26 p.m., Juan Luis Boya García wrote:
> > That's probably not a bug. See you have set 768 ms as stabilization time. This means the points painted will be the mean of those you actually drew during the last 768 ms. That's a huge time frame and fast movements are going to be cancelled or heavily deformed.
> > 
> > For most uses this param will be below 100-200 ms, which are already very high values; maybe raising it only for special things with very few curves. The scale is not the same as in the weighted smoothing.
> 
> Dmitry Kazakov wrote:
>     I just checked, this happens also on smaller length values (190ms). Create an image of 6000x5000px, set the zoom to 8% and try to paint a circle. You'll see effect.

Still I can't reproduce the issue.


- Juan Luis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118517/#review59247
-----------------------------------------------------------


On June 4, 2014, 11:13 a.m., Juan Luis Boya García wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118517/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 11:13 a.m.)
> 
> 
> Review request for Calligra, Dmitry Kazakov, Sven Langkamp, and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This commit adds to calligra a new stabilizer feature as an alternative
> to the current "Weigthed smoothing".
> 
> This stabilizer is very simple, calculating an arithmetic mean of the
> last N values (position, pressure and tilt) each millisecond and drawing
> a line from the previous point to there.
> 
> This takes into account both the length of the strokes and the speed
> they are made with.
> 
> Fast and small movements are considered erratic and are likely to be
> ignored yielding a mostly straight line.
> 
> On the other hand, slower and bigger movements are assumed to be
> deliberated and will follow the shape the user draws. The slower and
> bigger, the more accurate.
> 
> This process makes the strokes draw 'slowly'. The user sees how the line
> pursues their cursor. The effect is harder or softer depending on the N
> chosen (sample size), which is user-customizable.
> 
> Starting and end points are forced by the algorithm to be drawn exactly
> where the user began and ended the line.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/tools/defaulttools/kis_tool_brush.cc ceab3d8 
>   krita/ui/tool/kis_smoothing_options.h f2d5388 
>   krita/ui/tool/kis_tool_freehand_helper.h ee49086 
>   krita/ui/tool/kis_tool_freehand_helper.cpp aae08f1 
> 
> Diff: https://git.reviewboard.kde.org/r/118517/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Juan Luis Boya García
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140606/c66df4ff/attachment.htm>