<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118517/">https://git.reviewboard.kde.org/r/118517/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 4th, 2014, 9:26 p.m. UTC, <b>Juan Luis Boya García</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's probably not a bug. See you have set 768 ms as stabilization time. This means the points painted will be the mean of those you actually drew during the last 768 ms. That's a huge time frame and fast movements are going to be cancelled or heavily deformed.
For most uses this param will be below 100-200 ms, which are already very high values; maybe raising it only for special things with very few curves. The scale is not the same as in the weighted smoothing.</pre>
</blockquote>
<p>On June 5th, 2014, 5:56 a.m. UTC, <b>Dmitry Kazakov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just checked, this happens also on smaller length values (190ms). Create an image of 6000x5000px, set the zoom to 8% and try to paint a circle. You'll see effect.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Still I can't reproduce the issue.</pre>
<br />
<p>- Juan Luis</p>
<br />
<p>On June 4th, 2014, 11:13 a.m. UTC, Juan Luis Boya García wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Dmitry Kazakov, Sven Langkamp, and Boudewijn Rempt.</div>
<div>By Juan Luis Boya García.</div>
<p style="color: grey;"><i>Updated June 4, 2014, 11:13 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This commit adds to calligra a new stabilizer feature as an alternative
to the current "Weigthed smoothing".
This stabilizer is very simple, calculating an arithmetic mean of the
last N values (position, pressure and tilt) each millisecond and drawing
a line from the previous point to there.
This takes into account both the length of the strokes and the speed
they are made with.
Fast and small movements are considered erratic and are likely to be
ignored yielding a mostly straight line.
On the other hand, slower and bigger movements are assumed to be
deliberated and will follow the shape the user draws. The slower and
bigger, the more accurate.
This process makes the strokes draw 'slowly'. The user sees how the line
pursues their cursor. The effect is harder or softer depending on the N
chosen (sample size), which is user-customizable.
Starting and end points are forced by the algorithm to be drawn exactly
where the user began and ended the line.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/tools/defaulttools/kis_tool_brush.cc <span style="color: grey">(ceab3d8)</span></li>
<li>krita/ui/tool/kis_smoothing_options.h <span style="color: grey">(f2d5388)</span></li>
<li>krita/ui/tool/kis_tool_freehand_helper.h <span style="color: grey">(ee49086)</span></li>
<li>krita/ui/tool/kis_tool_freehand_helper.cpp <span style="color: grey">(aae08f1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118517/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>