Review Request 116533: Bug 142563

Jigar Raisinghani jigarraisinghani at gmail.com
Sun Jul 6 16:59:36 BST 2014



> On April 11, 2014, 4:39 a.m., Inge Wallin wrote:
> > sheets/functions/math.xml, line 836
> > <https://git.reviewboard.kde.org/r/116533/diff/2/?file=251413#file251413line836>
> >
> >     I'm not sure this text is an improvement. For one thing, it's not "greater than" if the number is already an integer.
> >     
> >     So at least it should be "...returns the smallest number equal to or greater than the input number" (notice that you shouldn't omit the "the").
> >     
> >     But actually I think "smallest integer" is better so I like the original text.

Yes, I agree with Inge. The correct way of putting it would be "The CEIL() function rounds x up to the smallest integer greater than or equal to the input number, returning that value as a floating point number."


- Jigar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116533/#review55424
-----------------------------------------------------------


On March 2, 2014, 3:12 p.m., Swarn Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116533/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 3:12 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 142563
>     http://bugs.kde.org/show_bug.cgi?id=142563
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Corrected definition of functions and their corresponding related functions.
> 
> 
> Diffs
> -----
> 
>   sheets/functions/math.xml 5b47291 
> 
> Diff: https://git.reviewboard.kde.org/r/116533/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Swarn Kumar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140706/47a188de/attachment.htm>


More information about the calligra-devel mailing list