Review Request 116990: Deduplicate dirs in one more place where moc fails due to too long command line.

Friedrich W. H. Kossebau kossebau at kde.org
Sun Jul 6 16:40:27 BST 2014



> On Juli 6, 2014, 3:12 nachm., Friedrich W. H. Kossebau wrote:
> > where is remove_duplicated_include_directories() from? could not find it documented in the cmake docs, and google does not tell me more.
> > 
> > Testing on my OpenSUSE I get:
> > CMake Error at sheets/shape/CMakeLists.txt:9 (remove_duplicated_include_directories):
> >   Unknown CMake command "remove_duplicated_include_directories".
> 
> Andrius da Costa Ribas wrote:
>     This was a macro created in: http://quickgit.kde.org/?p=calligra.git&a=commit&h=ea4e7267f6ba72189f0b2273c25c5c0de20f1792
>     Apparently it hadn't got merged back to master.

Ah, missed that this review request is only for 2.8 (right?), sorry. So please then follow Jarosław's ship it :)


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116990/#review61729
-----------------------------------------------------------


On März 23, 2014, 7:30 nachm., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116990/
> -----------------------------------------------------------
> 
> (Updated März 23, 2014, 7:30 nachm.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Deduplicate include dirs in one more place where moc fails due to too long command line by using remove_duplicated_include_directories() macro.
> 
> 
> Diffs
> -----
> 
>   sheets/shape/CMakeLists.txt f16b1a3 
> 
> Diff: https://git.reviewboard.kde.org/r/116990/diff/
> 
> 
> Testing
> -------
> 
> tested using MSVC and MinGW.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140706/76b92d2a/attachment.htm>


More information about the calligra-devel mailing list