Review Request 118532: Proper handling of sections for Words and Author

[Denis Kuplyakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118532/
-----------------------------------------------------------

(Updated July 3, 2014, 9:12 p.m.)


Review request for Calligra, Camilla Boemann, Inge Wallin, and Dan Leinir Turthra Jensen.


Changes
-------

Fixed wrong indication of section bug
    1) minor formatting issues and comment changes
    2) new APIs for KoSection, KoSectionEnd
    3) introduced KoSectionManager that handles sections and updates their info
    4) some FIXMEs for the future

Picked better icon for new section button

Fixed "Undo New section" message

Added new "Configure section" dialog
    Also fixed loading bug for KoSection


Repository: calligra


Description (updated)
-------

This adds proper section handling to code. It concentrates on managing to not break section structure during editing of text.
Patch fixes many things:
1) Insertion of text into sections
2) Deletion of text with sections
3) Cut, paste of text with sections
4) Applying style doesn't remove section info
5) WORDS product set added for fast building of Words and Author
6) Sections visual indication (need improvements)

Future TODOS:
1) improving section indication (DONE)
2) ability to insert section (DONE)
3) adding unittests
4) change icon for "New section" functionality (DONE)
5) we should read "Undo New section" in edit, after inserting new one (DONE)
6) fix indication of sections for multipage documents (DONE)


Diffs (updated)
-----

  libs/kotext/KoSectionUtils.h PRE-CREATION 
  libs/kotext/KoSectionManager.cpp PRE-CREATION 
  libs/kotext/KoSectionManager.h PRE-CREATION 
  libs/kotext/KoSectionEnd.h PRE-CREATION 
  libs/kotext/KoSectionEnd.cpp PRE-CREATION 
  libs/kotext/KoSection.cpp ca414b0 
  libs/kotext/CMakeLists.txt 44fa937 
  libs/kotext/KoSection.h ac3fdd8 
  libs/flake/KoShapePaintingContext.cpp 28ce859 
  libs/flake/KoShapePaintingContext.h a7d15fd 
  libs/flake/KoShapeLoadingContext.cpp 65c9cbe 
  libs/flake/KoCanvasResourceManager.h 2ad1c6f 
  libs/flake/KoShapeLoadingContext.h 1e7d196 
  libs/kotext/KoSectionUtils.cpp PRE-CREATION 
  libs/kotext/KoTextDocument.h 53c3d62 
  libs/kotext/KoTextDocument.cpp 1cb0931 
  libs/kotext/KoTextEditor.h 1fe289b 
  libs/kotext/KoTextEditor.cpp 574e803 
  libs/kotext/KoTextEditor_format.cpp a82352d 
  libs/kotext/KoTextPaste.cpp de89bd8 
  libs/kotext/commands/DeleteCommand.h f9dd2ef 
  libs/kotext/commands/DeleteCommand.cpp 391495e 
  libs/kotext/opendocument/KoTextLoader.h ca92573 
  libs/kotext/opendocument/KoTextLoader.cpp bf3044e 
  libs/kotext/opendocument/KoTextWriter_p.cpp c03cebb 
  libs/kundo2/kundo2magicstring.h f60f2a7 
  libs/odf/KoOdfPaste.cpp 1e46546 
  libs/textlayout/KoTextDocumentLayout.h 45a9ccb 
  libs/textlayout/KoTextLayoutArea.h f1b900a 
  libs/textlayout/KoTextLayoutArea_paint.cpp 2982c60 
  plugins/textshape/CMakeLists.txt f7fcdb4 
  plugins/textshape/TextShape.cpp 3b25ffe 
  plugins/textshape/TextTool.h 3409292 
  plugins/textshape/TextTool.cpp ae51513 
  plugins/textshape/dialogs/SectionFormatDialog.h PRE-CREATION 
  plugins/textshape/dialogs/SectionFormatDialog.cpp PRE-CREATION 
  plugins/textshape/dialogs/SectionFormatDialog.ui PRE-CREATION 
  plugins/textshape/dialogs/SimpleInsertWidget.cpp c2f083f 
  plugins/textshape/dialogs/SimpleInsertWidget.ui 4b9c639 
  words/part/CMakeLists.txt 41f675b 
  words/part/KWApplicationConfig.h 87f1016 
  words/part/KWApplicationConfig.cpp 1df6557 
  words/part/KWDocument.h 4bc53e1 
  words/part/KWDocument.cpp 533b8e1 
  words/part/KWFactory.cpp 9894f40 
  words/part/KWOdfLoader.cpp 4f82faa 
  words/part/KWView.h 50ee760 
  words/part/KWView.cpp 6456d1f 
  words/part/dockers/KWDebugDocker.h PRE-CREATION 
  words/part/dockers/KWDebugDocker.cpp PRE-CREATION 
  words/part/dockers/KWDebugDockerFactory.h PRE-CREATION 
  words/part/dockers/KWDebugDockerFactory.cpp PRE-CREATION 
  words/part/dockers/KWDebugWidget.h PRE-CREATION 
  words/part/dockers/KWDebugWidget.cpp PRE-CREATION 
  words/part/words.rc c3a9822 

Diff: https://git.reviewboard.kde.org/r/118532/diff/


Testing
-------

I have tested all functionality with emphasis on deletion. It has the most complicated code and need very good testing.
You can use LibreOffice Writer to create document with sections and then test editing it in words. And I will attach one I've used.


File Attachments
----------------

File for testing
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/04/f87d4ce2-3ab9-48a4-a880-4caa586790fc__Test-orig.odt


Thanks,

Denis Kuplyakov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140703/f925171e/attachment.htm>