<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118532/">https://git.reviewboard.kde.org/r/118532/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Camilla Boemann, Inge Wallin, and Dan Leinir Turthra Jensen.</div>
<div>By Denis Kuplyakov.</div>
<p style="color: grey;"><i>Updated July 3, 2014, 9:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed wrong indication of section bug
1) minor formatting issues and comment changes
2) new APIs for KoSection, KoSectionEnd
3) introduced KoSectionManager that handles sections and updates their info
4) some FIXMEs for the future
Picked better icon for new section button
Fixed "Undo New section" message
Added new "Configure section" dialog
Also fixed loading bug for KoSection</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds proper section handling to code. It concentrates on managing to not break section structure during editing of text.
Patch fixes many things:
1) Insertion of text into sections
2) Deletion of text with sections
3) Cut, paste of text with sections
4) Applying style doesn't remove section info
5) WORDS product set added for fast building of Words and Author
6) Sections visual indication (need improvements)
Future TODOS:
1) improving section indication (DONE)
2) ability to insert section (DONE)
3) adding unittests
4) change icon for "New section" functionality (DONE)
5) we should read "Undo New section" in edit, after inserting new one (DONE)
6) fix indication of sections for multipage documents (DONE)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested all functionality with emphasis on deletion. It has the most complicated code and need very good testing.
You can use LibreOffice Writer to create document with sections and then test editing it in words. And I will attach one I've used.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/KoSectionUtils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoSectionManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoSectionManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoSectionEnd.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoSectionEnd.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoSection.cpp <span style="color: grey">(ca414b0)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(44fa937)</span></li>
<li>libs/kotext/KoSection.h <span style="color: grey">(ac3fdd8)</span></li>
<li>libs/flake/KoShapePaintingContext.cpp <span style="color: grey">(28ce859)</span></li>
<li>libs/flake/KoShapePaintingContext.h <span style="color: grey">(a7d15fd)</span></li>
<li>libs/flake/KoShapeLoadingContext.cpp <span style="color: grey">(65c9cbe)</span></li>
<li>libs/flake/KoCanvasResourceManager.h <span style="color: grey">(2ad1c6f)</span></li>
<li>libs/flake/KoShapeLoadingContext.h <span style="color: grey">(1e7d196)</span></li>
<li>libs/kotext/KoSectionUtils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/kotext/KoTextDocument.h <span style="color: grey">(53c3d62)</span></li>
<li>libs/kotext/KoTextDocument.cpp <span style="color: grey">(1cb0931)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(1fe289b)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(574e803)</span></li>
<li>libs/kotext/KoTextEditor_format.cpp <span style="color: grey">(a82352d)</span></li>
<li>libs/kotext/KoTextPaste.cpp <span style="color: grey">(de89bd8)</span></li>
<li>libs/kotext/commands/DeleteCommand.h <span style="color: grey">(f9dd2ef)</span></li>
<li>libs/kotext/commands/DeleteCommand.cpp <span style="color: grey">(391495e)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.h <span style="color: grey">(ca92573)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(bf3044e)</span></li>
<li>libs/kotext/opendocument/KoTextWriter_p.cpp <span style="color: grey">(c03cebb)</span></li>
<li>libs/kundo2/kundo2magicstring.h <span style="color: grey">(f60f2a7)</span></li>
<li>libs/odf/KoOdfPaste.cpp <span style="color: grey">(1e46546)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.h <span style="color: grey">(45a9ccb)</span></li>
<li>libs/textlayout/KoTextLayoutArea.h <span style="color: grey">(f1b900a)</span></li>
<li>libs/textlayout/KoTextLayoutArea_paint.cpp <span style="color: grey">(2982c60)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(f7fcdb4)</span></li>
<li>plugins/textshape/TextShape.cpp <span style="color: grey">(3b25ffe)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey">(3409292)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(ae51513)</span></li>
<li>plugins/textshape/dialogs/SectionFormatDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SectionFormatDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SectionFormatDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleInsertWidget.cpp <span style="color: grey">(c2f083f)</span></li>
<li>plugins/textshape/dialogs/SimpleInsertWidget.ui <span style="color: grey">(4b9c639)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(41f675b)</span></li>
<li>words/part/KWApplicationConfig.h <span style="color: grey">(87f1016)</span></li>
<li>words/part/KWApplicationConfig.cpp <span style="color: grey">(1df6557)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(4bc53e1)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(533b8e1)</span></li>
<li>words/part/KWFactory.cpp <span style="color: grey">(9894f40)</span></li>
<li>words/part/KWOdfLoader.cpp <span style="color: grey">(4f82faa)</span></li>
<li>words/part/KWView.h <span style="color: grey">(50ee760)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(6456d1f)</span></li>
<li>words/part/dockers/KWDebugDocker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugDocker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugDockerFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugDockerFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/dockers/KWDebugWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/words.rc <span style="color: grey">(c3a9822)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118532/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/06/04/f87d4ce2-3ab9-48a4-a880-4caa586790fc__Test-orig.odt">File for testing</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>