Review Request 115129: Use kdewin's utsname.h instead of calling directly the equivalent winapi

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115129/#review47732
-----------------------------------------------------------

Ship it!


Great work!

- Jarosław Staniek


On Jan. 19, 2014, 6:08 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115129/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 6:08 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This partially reverts a previous commit of mine (3d4cbcc3f12cb50b8176352574a2d0315f0fdfb9 - "Don't use utsname on Windows but native api instead (also use Q_OS_* instead of Q_WS_*)."), but still using Q_OS_* instead of Q_WS_*. kdewin's implementation is more accurate.
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiUserFeedbackAgent.cpp b07407e 
>   sheets/functions/information.cpp 6dd51e2 
> 
> Diff: https://git.reviewboard.kde.org/r/115129/diff/
> 
> 
> Testing
> -------
> 
> Tested with both MSVC and MinGW, checking =INFO("osversion") on Sheets and user feedback agent on Kexi.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140119/66773882/attachment.htm>