Review Request 115129: Use kdewin's utsname.h instead of calling directly the equivalent winapi

Andrius da Costa Ribas andriusmao at gmail.com
Sun Jan 19 18:08:32 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115129/
-----------------------------------------------------------

Review request for Calligra and Jarosław Staniek.


Repository: calligra


Description
-------

This partially reverts a previous commit of mine (3d4cbcc3f12cb50b8176352574a2d0315f0fdfb9 - "Don't use utsname on Windows but native api instead (also use Q_OS_* instead of Q_WS_*)."), but still using Q_OS_* instead of Q_WS_*. kdewin's implementation is more accurate.


Diffs
-----

  kexi/main/KexiUserFeedbackAgent.cpp b07407e 
  sheets/functions/information.cpp 6dd51e2 

Diff: https://git.reviewboard.kde.org/r/115129/diff/


Testing
-------

Tested with both MSVC and MinGW, checking =INFO("osversion") on Sheets and user feedback agent on Kexi.


Thanks,

Andrius da Costa Ribas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140119/01094e0a/attachment.htm>


More information about the calligra-devel mailing list