Review Request 115856: Track changes better when switching from visual to SQL view

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115856/#review50311
-----------------------------------------------------------

Ship it!


Marking it as reviewed, 2.8 tagging in 2 days. I've been using this patch a couple of days. However please someone review it too.

- Jarosław Staniek


On Feb. 17, 2014, 10:56 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115856/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2014, 10:56 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Track changes better when switching from visual to SQL view
> 
> Query statement should be updated when needed in the SQL view.
> For this to work designer's "query changed in previous view" flag should be more carefully managed.
> 
> +add helper methods for easier debugging of the flag
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/queries/kexiquerydesignerguieditor.h d7189422862d4f4e8d9d8e843d88b3eed53a483f 
>   kexi/plugins/queries/kexiquerydesignerguieditor.cpp 2ce945aa5900c99ea4fb80492eac98d578810f16 
>   kexi/plugins/queries/kexiquerydesignersql.cpp df295fcbf053a8c69812d4b2a7f686424e93b97f 
>   kexi/plugins/queries/kexiquerypart.h 800a3120f0f7ad98ea1d199f4c5e9f9ae41ad8c5 
>   kexi/plugins/queries/kexiquerypart.cpp 4f0b6616eddf2bd13bcac6327aaf215d88562831 
>   kexi/plugins/queries/kexiqueryview.cpp be05b3c823d074985cc7df3222481cd957bf583a 
>   kexi/widget/dataviewcommon/kexidataawarepropertyset.h d89e7e08185026c3fa24abb7f69648ca84055bb1 
>   kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp 2ebb2702551b1935b0d68cd93aa71ff8430561d1 
>   libs/db/parser/parser_p.cpp f6f39f1be4031ae49cc23da9f442ffcf5208b075 
> 
> Diff: https://git.reviewboard.kde.org/r/115856/diff/
> 
> 
> Testing
> -------
> 
> Tested with the db attached to bug #331259
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140220/90b176f1/attachment.htm>