<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115856/">https://git.reviewboard.kde.org/r/115856/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marking it as reviewed, 2.8 tagging in 2 days. I've been using this patch a couple of days. However please someone review it too.</pre>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On February 17th, 2014, 10:56 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2014, 10:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Track changes better when switching from visual to SQL view
Query statement should be updated when needed in the SQL view.
For this to work designer's "query changed in previous view" flag should be more carefully managed.
+add helper methods for easier debugging of the flag</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with the db attached to bug #331259</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/plugins/queries/kexiquerydesignerguieditor.h <span style="color: grey">(d7189422862d4f4e8d9d8e843d88b3eed53a483f)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.cpp <span style="color: grey">(2ce945aa5900c99ea4fb80492eac98d578810f16)</span></li>
<li>kexi/plugins/queries/kexiquerydesignersql.cpp <span style="color: grey">(df295fcbf053a8c69812d4b2a7f686424e93b97f)</span></li>
<li>kexi/plugins/queries/kexiquerypart.h <span style="color: grey">(800a3120f0f7ad98ea1d199f4c5e9f9ae41ad8c5)</span></li>
<li>kexi/plugins/queries/kexiquerypart.cpp <span style="color: grey">(4f0b6616eddf2bd13bcac6327aaf215d88562831)</span></li>
<li>kexi/plugins/queries/kexiqueryview.cpp <span style="color: grey">(be05b3c823d074985cc7df3222481cd957bf583a)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.h <span style="color: grey">(d89e7e08185026c3fa24abb7f69648ca84055bb1)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp <span style="color: grey">(2ebb2702551b1935b0d68cd93aa71ff8430561d1)</span></li>
<li>libs/db/parser/parser_p.cpp <span style="color: grey">(f6f39f1be4031ae49cc23da9f442ffcf5208b075)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115856/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>