Review Request 115489: Improve focus, keyboard interaction and painting in table and form views

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115489/#review50309
-----------------------------------------------------------

Ship it!


Marking it as reviewed, 2.8 tagging in 2 days.

- Jarosław Staniek


On Feb. 8, 2014, 10:21 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115489/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2014, 10:21 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.
> 
> 
> Bugs: 304989 and 329892
>     http://bugs.kde.org/show_bug.cgi?id=304989
>     http://bugs.kde.org/show_bug.cgi?id=329892
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> - Focus combo box after accepting or cancelling selection in combo popup
> - Show focus in combo box after accepting or cancelling row changes
> - Remove focus from combo box after clicking outside of its popup
> - Improve appearance of combo box' button in table view
> - Fix missing re-display of table view combo box popup
> - Fix focus in table view combo box popup
> - Make clipboard shortcuts work again in table view cells
> - Properly set focus inside table view after activation
> 
> 
> Diffs
> -----
> 
>   kexi/widget/utils/kexicomboboxdropdownbutton.cpp 359101bbeec022a3595b1859d85dc2985df435cc 
>   kexi/core/KexiWindow.cpp 16292c8ef1e0e61f7dba03dd2220676f75657701 
>   kexi/plugins/forms/kexiformscrollview.cpp 205d57dd2eee754760e49abb4a2d541932da4515 
>   kexi/plugins/forms/widgets/kexidbcombobox.h ee7c89af514ff71a9296692023533d5fcf3519e6 
>   kexi/plugins/forms/widgets/kexidbcombobox.cpp 8c729be94f86ecb455a60b5b84dcb97217849990 
>   kexi/plugins/forms/widgets/kexidbform.cpp 7518d15e9ca1b5ddcf0d556edb8fc7a33ee6c1fc 
>   kexi/widget/dataviewcommon/kexidataawareview.h 3a20984166722e5bee54fce6490f6b64425ee5bd 
>   kexi/widget/dataviewcommon/kexidataawareview.cpp c75022bf992375a7b89eabc01bd03624c138a261 
>   kexi/widget/tableview/kexicomboboxbase.h 9f3bac8a3377376880ed7d5986febb35b7e645a4 
>   kexi/widget/tableview/kexicomboboxbase.cpp 097ab24a12e7f0d79f9731d016f7266cdbaaabf4 
>   kexi/widget/tableview/kexicomboboxpopup.cpp ecee4cf41245f8c2424483386ed1fbb056d53670 
>   kexi/widget/tableview/kexicomboboxtableedit.cpp 599660cfb3b470e899fd52bb6c08eba84cd78c6a 
>   kexi/widget/tableview/kexitableview.h 53992981f9d5fe1c6179acf05bc68e2628cd9a73 
>   kexi/widget/tableview/kexitableview.cpp 4303c3f9fc48ed1986148f1abde3d620c0b83563 
>   kexi/widget/utils/kexicomboboxdropdownbutton.h 7907284c3899a95926e16d8f427c4ec09c16e2e8 
> 
> Diff: https://git.reviewboard.kde.org/r/115489/diff/
> 
> 
> Testing
> -------
> 
> Tested with tables and forms, see the test db at https://bugs.kde.org/show_bug.cgi?id=329141#c1 and table bar, form frmbar
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140220/1062ee8e/attachment.htm>