<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115489/">https://git.reviewboard.kde.org/r/115489/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marking it as reviewed, 2.8 tagging in 2 days.</pre>
<br />
<p>- Jarosław Staniek</p>
<br />
<p>On February 8th, 2014, 10:21 p.m. UTC, Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, and Radosław Wicik.</div>
<div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2014, 10:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=304989">304989</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=329892">329892</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Focus combo box after accepting or cancelling selection in combo popup
- Show focus in combo box after accepting or cancelling row changes
- Remove focus from combo box after clicking outside of its popup
- Improve appearance of combo box' button in table view
- Fix missing re-display of table view combo box popup
- Fix focus in table view combo box popup
- Make clipboard shortcuts work again in table view cells
- Properly set focus inside table view after activation
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with tables and forms, see the test db at https://bugs.kde.org/show_bug.cgi?id=329141#c1 and table bar, form frmbar</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/widget/utils/kexicomboboxdropdownbutton.cpp <span style="color: grey">(359101bbeec022a3595b1859d85dc2985df435cc)</span></li>
<li>kexi/core/KexiWindow.cpp <span style="color: grey">(16292c8ef1e0e61f7dba03dd2220676f75657701)</span></li>
<li>kexi/plugins/forms/kexiformscrollview.cpp <span style="color: grey">(205d57dd2eee754760e49abb4a2d541932da4515)</span></li>
<li>kexi/plugins/forms/widgets/kexidbcombobox.h <span style="color: grey">(ee7c89af514ff71a9296692023533d5fcf3519e6)</span></li>
<li>kexi/plugins/forms/widgets/kexidbcombobox.cpp <span style="color: grey">(8c729be94f86ecb455a60b5b84dcb97217849990)</span></li>
<li>kexi/plugins/forms/widgets/kexidbform.cpp <span style="color: grey">(7518d15e9ca1b5ddcf0d556edb8fc7a33ee6c1fc)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.h <span style="color: grey">(3a20984166722e5bee54fce6490f6b64425ee5bd)</span></li>
<li>kexi/widget/dataviewcommon/kexidataawareview.cpp <span style="color: grey">(c75022bf992375a7b89eabc01bd03624c138a261)</span></li>
<li>kexi/widget/tableview/kexicomboboxbase.h <span style="color: grey">(9f3bac8a3377376880ed7d5986febb35b7e645a4)</span></li>
<li>kexi/widget/tableview/kexicomboboxbase.cpp <span style="color: grey">(097ab24a12e7f0d79f9731d016f7266cdbaaabf4)</span></li>
<li>kexi/widget/tableview/kexicomboboxpopup.cpp <span style="color: grey">(ecee4cf41245f8c2424483386ed1fbb056d53670)</span></li>
<li>kexi/widget/tableview/kexicomboboxtableedit.cpp <span style="color: grey">(599660cfb3b470e899fd52bb6c08eba84cd78c6a)</span></li>
<li>kexi/widget/tableview/kexitableview.h <span style="color: grey">(53992981f9d5fe1c6179acf05bc68e2628cd9a73)</span></li>
<li>kexi/widget/tableview/kexitableview.cpp <span style="color: grey">(4303c3f9fc48ed1986148f1abde3d620c0b83563)</span></li>
<li>kexi/widget/utils/kexicomboboxdropdownbutton.h <span style="color: grey">(7907284c3899a95926e16d8f427c4ec09c16e2e8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115489/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>