Review Request 115314: Fix crash with custom sized reports

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115314/#review50205
-----------------------------------------------------------


Andrius,
Tested the patch, it looks much better, thanks. 

Notes:
1. We have missed change in KoReportReportData::KoReportReportData() report:custom-page-* -> fo:custom-page-*. After this fix, setting size to A5, A6, etc. works again.
2. When I print custom sized reports to a PDF (but probably also to a real printer), it always prints A4. Don't we miss a QPrinter::setPaperSize ( const QSizeF & paperSize, Unit unit ) call or so? 
   Moreover  QPrinter::setPageSize ( PageSize newPageSize ) is obsolete method, QPrinter::setPaperSize ( PaperSize newPaperSize ) should be used.
3. Preview mode does not show realistic page geometry, eg when I set Custom 5x5cm page size. This could be fixed later if there's no time.


- Jarosław Staniek


On Feb. 16, 2014, 6:11 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115314/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 6:11 p.m.)
> 
> 
> Review request for Calligra, Friedrich W. H. Kossebau, Adam Pigg, and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch enables "Custom" sized reports which were not working before.
> 
> 
> Diffs
> -----
> 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 7644c1d 
> 
> Diff: https://git.reviewboard.kde.org/r/115314/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC, with both Plan and Kexi reports.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140219/3f031af8/attachment.htm>