Review Request 115314: Fix crash with custom sized reports
Andrius da Costa Ribas
andriusmao at gmail.com
Sun Feb 16 18:11:10 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115314/
-----------------------------------------------------------
(Updated Feb. 16, 2014, 6:11 p.m.)
Review request for Calligra, Friedrich W. H. Kossebau, Adam Pigg, and Jarosław Staniek.
Changes
-------
* fixed the items pointed by @staniek
* fixed ::pageWidthPx method with custom size (width is always the correct width here, regardless the orientation chosen)
* use double instead of qreal to keep consistency across platforms.
* save width and height even when it's predefined
* don't add report:page-style/$TEXT="custom" for custom size
Repository: calligra
Description
-------
This patch enables "Custom" sized reports which were not working before.
Diffs (updated)
-----
libs/koreport/wrtembed/KoReportDesigner.cpp 7644c1d
Diff: https://git.reviewboard.kde.org/r/115314/diff/
Testing
-------
Tested using MSVC, with both Plan and Kexi reports.
Thanks,
Andrius da Costa Ribas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140216/ae4b9c7a/attachment.htm>
More information about the calligra-devel
mailing list