Review Request 121733: Fix crash reported in bug 342222

Thorsten Zachmann t.zachmann at zagge.de
Tue Dec 30 06:14:17 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121733/
-----------------------------------------------------------

(Updated Dec. 30, 2014, 6:14 a.m.)


Review request for Calligra.


Changes
-------

Make sure to not leak memory as pointed out by Dmitry.


Bugs: 342222
    http://bugs.kde.org/show_bug.cgi?id=342222


Repository: calligra


Description
-------

For shapes that are created in the document a KoShapeController is set. However when loading a shape this is not set as it is not available in the factory. This results in a crash when pasting as there the KoShapeController is needed. Therefore create a KoShapeController which can be set on text shapes during loading. This is done the same in kopageapp and words.


Diffs (updated)
-----

  krita/ui/KisDocument.cpp 00a1e68 

Diff: https://git.reviewboard.kde.org/r/121733/diff/


Testing
-------

Opened a .kra file with a text shape and pasted text to it.


Thanks,

Thorsten Zachmann

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141230/fe430c61/attachment.htm>


More information about the calligra-devel mailing list