Review Request 121733: Fix crash reported in bug 342222

[Dmitry Kazakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121733/#review72677
-----------------------------------------------------------


Hi, Thorsten!

The patch looks ok except one thing. Are you sure the shape controller is deleted somewhere? As far as I understood, the ownership of it is not passed to the document resource manager. It just stores a pointer insize QVariant, so it seems like the shape controller is leaking :(

- Dmitry Kazakov


On Dec. 29, 2014, 3:59 a.m., Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121733/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2014, 3:59 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Bugs: 342222
>     http://bugs.kde.org/show_bug.cgi?id=342222
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> For shapes that are created in the document a KoShapeController is set. However when loading a shape this is not set as it is not available in the factory. This results in a crash when pasting as there the KoShapeController is needed. Therefore create a KoShapeController which can be set on text shapes during loading. This is done the same in kopageapp and words.
> 
> 
> Diffs
> -----
> 
>   krita/ui/KisDocument.cpp 00a1e68 
> 
> Diff: https://git.reviewboard.kde.org/r/121733/diff/
> 
> 
> Testing
> -------
> 
> Opened a .kra file with a text shape and pasted text to it.
> 
> 
> Thanks,
> 
> Thorsten Zachmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141229/98fbe138/attachment.htm>