Review Request 121509: CMake module for detecting marble with Marble marble version.

Radosław Wicik radoslaw at wicik.pl
Wed Dec 17 23:11:17 GMT 2014



> On Gru 17, 2014, 11:01 po południu, Jarosław Staniek wrote:
> > Nice! Are we going to check values of MARBLE_VERSION* variables? What's minimal version accordint to your test?

Yes, version depends, currentlly used api is 0.10 or even older, but new api is available from 0.16 (current is 0.19).
Version checking will be added with next patch, with updated API.


- Radosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121509/#review72209
-----------------------------------------------------------


On Gru 16, 2014, 11:26 po południu, Radosław Wicik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121509/
> -----------------------------------------------------------
> 
> (Updated Gru 16, 2014, 11:26 po południu)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> CMake module for detecting Marble with version detection.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt aa9202ca75ba3ec7eaf09f59caf975ada7ad5945 
>   cmake/modules/FindCalligraMarble.cmake PRE-CREATION 
>   cmake/modules/FindMarble.cmake 9c232cb45ab51f623aca20d605fa85760e177dd5 
> 
> Diff: https://git.reviewboard.kde.org/r/121509/diff/
> 
> 
> Testing
> -------
> 
> Configuration and build
> 
> 
> Thanks,
> 
> Radosław Wicik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141217/54be89a0/attachment.htm>


More information about the calligra-devel mailing list