Review Request 121509: CMake module for detecting marble with Marble marble version.

Friedrich W. H. Kossebau kossebau at kde.org
Wed Dec 17 22:09:55 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121509/#review72210
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/121509/#comment50372>

    Please no unrelated drive-by whitespace cleanups. This only results in hard-to understand commit history.
    
    Thus the only change here should be the line with
    
    macro_optional_find_package(CalligraMarble)


- Friedrich W. H. Kossebau


On Dez. 16, 2014, 10:26 nachm., Radosław Wicik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121509/
> -----------------------------------------------------------
> 
> (Updated Dez. 16, 2014, 10:26 nachm.)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> CMake module for detecting Marble with version detection.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt aa9202ca75ba3ec7eaf09f59caf975ada7ad5945 
>   cmake/modules/FindCalligraMarble.cmake PRE-CREATION 
>   cmake/modules/FindMarble.cmake 9c232cb45ab51f623aca20d605fa85760e177dd5 
> 
> Diff: https://git.reviewboard.kde.org/r/121509/diff/
> 
> 
> Testing
> -------
> 
> Configuration and build
> 
> 
> Thanks,
> 
> Radosław Wicik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141217/e6457a5b/attachment.htm>


More information about the calligra-devel mailing list