Review Request 121359: Add transparency to selection decoration

Boudewijn Rempt boud at valdyas.org
Mon Dec 15 13:41:25 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121359/#review72056
-----------------------------------------------------------

Ship it!


Good point -- but let's have a line of comment explaining the numbers.

- Boudewijn Rempt


On Dec. 5, 2014, 4:07 p.m., Timothée Giet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121359/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 4:07 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Add transparency to selection decoration
> 
> 
> Diffs
> -----
> 
>   plugins/defaultTools/defaulttool/SelectionDecorator.cpp 1607dc2 
> 
> Diff: https://git.reviewboard.kde.org/r/121359/diff/
> 
> 
> Testing
> -------
> 
> I noticed some usability issues with current selection decoration that's hiding too much what's below.
> That is especially bad when selecting a rectangle shape with oultine smaller than decoration.
> 
> This patch adds some transparency to selection decoration color, improving a lot usability.
> 
> 
> Thanks,
> 
> Timothée Giet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141215/c00cd2ae/attachment.htm>


More information about the calligra-devel mailing list