Review Request 120733: Pass more data between layout and RootAreaProvider

[Dan Leinir Turthra Jensen]

This is, i know, somewhat late in the review phase, but i expect it's a 
smallish issue anyway. In short, 4fa0b6e29d31d7755441b231ea3bf2ef068435b4 
breaks text input in Stage. Which i discovered while setting out to make a 
presentation i've got to give on Monday ;)

On Wednesday 22 Oct 2014 21:44:10 Pierre Ducroquet wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120733/
> -----------------------------------------------------------
> 
> Review request for Calligra and Camilla Boemann.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch refactors a bit the KoTextLayoutRootAreaProvider.
> It extends the provideNext call by adding a constraints structure.
> This structure contains so far the masterPageName and the page
> number of the requested new rootArea.
> This way, the provider don't have to sneak in layout specific data.
> It also adds a way for KoTextLayoutRootAreaProvider to help the
> layout and fix inserting a new page (by adding lines to a paragraph
> for instance) before a page break changing the page style.
> 
> Some more explanations regarding this bug :
> - Page 1, style AAA
> * page break, requesting style BBB
> - Page 2, style BBB
> 
> If you add more data to the page 1, then dynamically the layout should
> do :
> - Page 1, style AAA
> - Page 2, style AAA
> * page break, requesting style BBB
> - Page 3, style BBB
> 
> But the layout did recycle the page 2, leading to :
> - Page 1, style AAA
> - Page 2, style BBB
> * page break, requesting style BBB
> - Page 3, style BBB
> 
> Reloading the document leads to a correct layout.
> 
> 
> Diffs
> -----
> 
>   plugins/textshape/SimpleRootAreaProvider.h
> afada40af1ea3341a820dc0d275a2db5bbb5a3f8
> plugins/textshape/SimpleRootAreaProvider.cpp
> 42df2ecd30aa744780642618556a7013a9ff27da words/part/KWRootAreaProvider.h
> 8fb9b5e379a0561fceb7ba32935084df46ce6fd9 words/part/KWRootAreaProvider.cpp
> 62b6fb6fba4dea8d9f68b0b3c1afb7324c50d502
> libs/textlayout/KoTextDocumentLayout.cpp
> 805f11d1c4aaf90a1a2a654053889e06800193de
> libs/textlayout/KoTextLayoutRootAreaProvider.h
> 23b91bc519761eef2861fc6fc4546294271389cc
> libs/textlayout/tests/MockRootAreaProvider.h
> 23056384fb55918ae360ad062d5dfd13ee7c4837
> libs/textlayout/tests/MockRootAreaProvider.cpp
> 0402528998c26cfb586f297abe7c879459adda50
> 
> Diff: https://git.reviewboard.kde.org/r/120733/diff/
> 
> 
> Testing
> -------
> 
> A simple document with page styles (changing the background color to help
> speed up the development) now doesn't exhibit the wrong layout behaviour.
> 
> 
> Thanks,
> 
> Pierre Ducroquet

-- 
..Dan // Leinir..
http://leinir.dk/

                          Co-
                            existence
                          or no
                            existence

                          - Piet Hein