Review Request 121509: CMake module for detecting marble with Marble marble version.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121509/#review72048
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/121509/#comment50239>

    I noticed that. My workaround e.g. for postgresql was to use somewhat different name, so I used FindCalligraPostgreSQL.cmake instead of FindPostgreSQL.cmake --> no clash with system name.
    
    So I propose using FindCalligraMarble.cmake name and not fighting with the PATH changes.


- Jarosław Staniek


On Dec. 14, 2014, 4:28 p.m., Radosław Wicik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121509/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2014, 4:28 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> CMake module for detecting marble with Marble marble version.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt aa9202ca75ba3ec7eaf09f59caf975ada7ad5945 
>   cmake/modules/FindMarble.cmake 9c232cb45ab51f623aca20d605fa85760e177dd5 
> 
> Diff: https://git.reviewboard.kde.org/r/121509/diff/
> 
> 
> Testing
> -------
> 
> Configuration and build
> 
> 
> Thanks,
> 
> Radosław Wicik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141215/4e0dcafc/attachment.htm>