Review Request 121509: CMake module for detecting marble with Marble marble version.

[Jarosław Staniek]

> On Dec. 14, 2014, 4:32 p.m., Radosław Wicik wrote:
> > cmake/modules/FindMarble.cmake, lines 17-30
> > <https://git.reviewboard.kde.org/r/121509/diff/1/?file=333154#file333154line17>
> >
> >     I'm not sure how to handle the license,
> >     function(from_hex HEX DEC) is copied for FindOpenSSL.cmake, do we need something more or less here?

OK. We're using this license for all our .cmake modules.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121509/#review71985
-----------------------------------------------------------


On Dec. 14, 2014, 4:28 p.m., Radosław Wicik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121509/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2014, 4:28 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> CMake module for detecting marble with Marble marble version.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt aa9202ca75ba3ec7eaf09f59caf975ada7ad5945 
>   cmake/modules/FindMarble.cmake 9c232cb45ab51f623aca20d605fa85760e177dd5 
> 
> Diff: https://git.reviewboard.kde.org/r/121509/diff/
> 
> 
> Testing
> -------
> 
> Configuration and build
> 
> 
> Thanks,
> 
> Radosław Wicik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141215/2889b518/attachment.htm>