Review Request 119502: Use unset(..) instead of set(..) to unset CMake variables
Elvis Stansvik
elvstone at gmail.com
Mon Aug 4 17:33:09 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119502/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 4:33 p.m.)
Status
------
This change has been discarded.
Review request for Calligra and Friedrich W. H. Kossebau.
Repository: calligra
Description
-------
It's slightly more clear to non-CMake wizards to use `unset(MY_VAR)` instead of `set(MY_VAR)` to unset a variable. I found such places with the slightly ugly command
find . ( -name "*.cmake" -o -name "CMakeLists.txt" ) -exec egrep -Hn "(^|\s+)[sS][eE][tT][ ]*([ ]*[^ ]+[ ]*)" {} \;
and changed them to use `unset(..)` instead.
Diffs
-----
cmake/modules/FindICU.cmake 46671c8
cmake/modules/FindIconv.cmake ce40ab2
cmake/modules/FindPoppler.cmake 534acbc
cmake/modules/MacroCalligraAddBenchmark.cmake 2178adf
krita/CMakeLists.txt 3668a56
krita/benchmarks/CMakeLists.txt 86794a5
libs/pigment/CMakeLists.txt fb1a54f
plugins/colorengines/lcms2/CMakeLists.txt ae4d140
cmake/modules/CalligraProductSetMacros.cmake 8b0492b
Diff: https://git.reviewboard.kde.org/r/119502/diff/
Testing
-------
Did a default CMake run. Everything seemed fine, the semantics should not have changed.
Thanks,
Elvis Stansvik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140804/67e0efff/attachment.htm>
More information about the calligra-devel
mailing list