<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119502/">https://git.reviewboard.kde.org/r/119502/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Friedrich W. H. Kossebau.</div>
<div>By Elvis Stansvik.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2014, 4:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's slightly more clear to non-CMake wizards to use <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">unset(MY_VAR)</code> instead of <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">set(MY_VAR)</code> to unset a variable. I found such places with the slightly ugly command</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">find . <span style="border: 1px solid #FF0000">\</span>( <span style="color: #666666">-</span>name <span style="color: #BA2121">"*.cmake"</span> <span style="color: #666666">-</span>o <span style="color: #666666">-</span>name <span style="color: #BA2121">"CMakeLists.txt"</span> <span style="border: 1px solid #FF0000">\</span>) <span style="color: #666666">-</span>exec egrep <span style="color: #666666">-</span>Hn <span style="color: #BA2121">"(^|\s+)[sS][eE][tT][ ]*\([ ]*[^ ]+[ ]*\)"</span> {} <span style="border: 1px solid #FF0000">\</span>;
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and changed them to use <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">unset(..)</code> instead.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Did a default CMake run. Everything seemed fine, the semantics should not have changed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindICU.cmake <span style="color: grey">(46671c8)</span></li>
<li>cmake/modules/FindIconv.cmake <span style="color: grey">(ce40ab2)</span></li>
<li>cmake/modules/FindPoppler.cmake <span style="color: grey">(534acbc)</span></li>
<li>cmake/modules/MacroCalligraAddBenchmark.cmake <span style="color: grey">(2178adf)</span></li>
<li>krita/CMakeLists.txt <span style="color: grey">(3668a56)</span></li>
<li>krita/benchmarks/CMakeLists.txt <span style="color: grey">(86794a5)</span></li>
<li>libs/pigment/CMakeLists.txt <span style="color: grey">(fb1a54f)</span></li>
<li>plugins/colorengines/lcms2/CMakeLists.txt <span style="color: grey">(ae4d140)</span></li>
<li>cmake/modules/CalligraProductSetMacros.cmake <span style="color: grey">(8b0492b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119502/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>