Review Request 119569: Fixed recognition of the Wacom Stylus serial id

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119569/#review63660
-----------------------------------------------------------

Ship it!


- Boudewijn Rempt


On Aug. 2, 2014, 6:56 a.m., Dmitry Kazakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119569/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2014, 6:56 a.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch does two fixes:
> 
> 1) Implements fetching of the stylus ID using X11 properties, instead of using 'libwacomcfg', which has been deprecated long ago (and not shipped with any known distributions anymore).
> 
> Qt 4.8 still has code for fetching this library dynamically on the fly but surely enough it doesn't work (serial is always 0), because the library is deprecated. I cannot tell exactly what is the status in Qt5.
> 
> 2) Removed the event filter from the KoToolManager. Installing this event filter purely for calling switchInputDevice() is useless, because switchInputDevice() will be called later in the event handlers. So we won't do the work twice.
> 
> 
> Diffs
> -----
> 
>   krita/ui/input/wintab/kis_tablet_support_x11.cpp 3670380 
>   krita/ui/input/wintab/wacom-properties.h PRE-CREATION 
>   krita/ui/input/wintab/wacomcfg.h 03528df 
>   libs/flake/KoToolManager.h 17b718e 
>   libs/flake/KoToolManager.cpp 2990b62 
> 
> Diff: https://git.reviewboard.kde.org/r/119569/diff/
> 
> 
> Testing
> -------
> 
> Tested in Krita
> 
> 
> Thanks,
> 
> Dmitry Kazakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140802/0f38c05e/attachment.htm>