<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119569/">https://git.reviewboard.kde.org/r/119569/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Boudewijn Rempt</p>
<br />
<p>On August 2nd, 2014, 6:56 a.m. UTC, Dmitry Kazakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Dmitry Kazakov.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2014, 6:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch does two fixes:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) Implements fetching of the stylus ID using X11 properties, instead of using 'libwacomcfg', which has been deprecated long ago (and not shipped with any known distributions anymore).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Qt 4.8 still has code for fetching this library dynamically on the fly but surely enough it doesn't work (serial is always 0), because the library is deprecated. I cannot tell exactly what is the status in Qt5.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2) Removed the event filter from the KoToolManager. Installing this event filter purely for calling switchInputDevice() is useless, because switchInputDevice() will be called later in the event handlers. So we won't do the work twice.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested in Krita</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/ui/input/wintab/kis_tablet_support_x11.cpp <span style="color: grey">(3670380)</span></li>
<li>krita/ui/input/wintab/wacom-properties.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>krita/ui/input/wintab/wacomcfg.h <span style="color: grey">(03528df)</span></li>
<li>libs/flake/KoToolManager.h <span style="color: grey">(17b718e)</span></li>
<li>libs/flake/KoToolManager.cpp <span style="color: grey">(2990b62)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119569/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>