Review Request 117797: Fix for Kexi crash in DebugGUI mode

[Jaroslaw Staniek]

Hi Wojciech,
1. See http://techbase.kde.org/Policies/Commit_Policy

2. The first time may be uneasy, please make sure you have just one commit
when you type in master branch:

git cherry origin/master -v

and in 2.8 branch:

git cherry origin/calligra/2.8 -v

3. Read the explanation in the commit template:
http://techbase.kde.org/Development/Git/Configuration
and install the template as suggested.

4. Once the commit message is finally crafted, create a patch using:
git format-patch -1 {HASH_OF_THIS_COMMIT}

..and send me in email.

I'll give OK when it's allright.



On 29 April 2014 21:12, Wojciech Kosowicz <pcellix at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117797/
>
> On April 28th, 2014, 10:36 p.m. UTC, *Jarosław Staniek* wrote:
>
> Good job!
>
>  On April 29th, 2014, 6:37 p.m. UTC, *Wojciech Kosowicz* wrote:
>
> thank you :). Where to find information should look like? I understand I should push to it master? If the there is something wiki page regarding the subject please share it :)
>
>  I'm sorry I didn't express myself well. The question was regarding how final commit should look like and where and how push it to the repository
>
>
> - Wojciech
>
> On April 28th, 2014, 9:50 p.m. UTC, Wojciech Kosowicz wrote:
>   Review request for Calligra and Jarosław Staniek.
> By Wojciech Kosowicz.
>
> *Updated April 28, 2014, 9:50 p.m.*
>  *Bugs: * 333933 <http://bugs.kde.org/show_bug.cgi?id=333933>
>  *Repository: * calligra
> Description
>
> This patch adds additional check if there is no null pointer. If so first item is created
>
>   Testing
>
> Kexi stopped to crashed in DebugGUI mode
>
>   Diffs
>
>    - kexi/kexiutils/debuggui.cpp (fb22bfb)
>
> View Diff <https://git.reviewboard.kde.org/r/117797/diff/>
>



-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
 Qt for Tizen | http://qt-project.org/wiki/Tizen
 Qt Certified Specialist | http://www.linkedin.com/in/jstaniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140429/097ca26e/attachment.htm>