<div dir="ltr"><div class="gmail_default" style="font-family:courier new,monospace;font-size:large">Hi Wojciech,<br>1. See <a href="http://techbase.kde.org/Policies/Commit_Policy">http://techbase.kde.org/Policies/Commit_Policy</a><br>
<br></div><div class="gmail_default" style="font-family:courier new,monospace;font-size:large">2. The first time may be uneasy, please make sure you have just one commit when you type in master branch:<br></div><div class="gmail_default" style="font-family:courier new,monospace;font-size:large">
<br>git cherry origin/master -v<br><br>and in 2.8 branch:<br><br>git cherry origin/calligra/2.8 -v<br><br></div><div class="gmail_default" style="font-family:courier new,monospace;font-size:large">3. Read the explanation in the commit template:<br>
<a href="http://techbase.kde.org/Development/Git/Configuration">http://techbase.kde.org/Development/Git/Configuration</a><br></div><div class="gmail_default" style="font-family:courier new,monospace;font-size:large">and install the template as suggested.<br>
<br></div><div class="gmail_default" style="font-family:courier new,monospace;font-size:large">4. Once the commit message is finally crafted, create a patch using:<br>git format-patch -1 {HASH_OF_THIS_COMMIT}<br><br></div>
<div class="gmail_default" style="font-family:courier new,monospace;font-size:large">..and send me in email.<br></div><div class="gmail_default" style="font-family:courier new,monospace;font-size:large"><br></div><div class="gmail_default" style="font-family:courier new,monospace;font-size:large">
I'll give OK when it's allright.<br></div><div class="gmail_default" style="font-family:courier new,monospace;font-size:large"><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 29 April 2014 21:12, Wojciech Kosowicz <span dir="ltr"><<a href="mailto:pcellix@gmail.com" target="_blank">pcellix@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117797/" target="_blank">https://git.reviewboard.kde.org/r/117797/</a>
</td>
</tr>
</tbody></table>
<br>
</div><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px"><div class="">
<p style="margin-top:0">On April 28th, 2014, 10:36 p.m. UTC, <b>Jarosław Staniek</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Good job!</pre>
</blockquote>
</div><div class=""><p>On April 29th, 2014, 6:37 p.m. UTC, <b>Wojciech Kosowicz</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">thank you :). Where to find information should look like? I understand I should push to it master? If the there is something wiki page regarding the subject please share it :)
</pre>
</blockquote>
</div></blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I'm sorry I didn't express myself well. The question was regarding how final commit should look like and where and how push it to the repository</pre>
<span class="HOEnZb"><font color="#888888">
<br>
<p>- Wojciech</p></font></span><div class="">
<br>
<p>On April 28th, 2014, 9:50 p.m. UTC, Wojciech Kosowicz wrote:</p>
<table style="background-image:url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');background-repeat:repeat-x;border:1px black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Wojciech Kosowicz.</div>
<p style="color:grey"><i>Updated April 28, 2014, 9:50 p.m.</i></p>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333933" target="_blank">333933</a>
</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
calligra
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This patch adds additional check if there is no null pointer. If so first item is created</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" width="100%">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Kexi stopped to crashed in DebugGUI mode</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>kexi/kexiutils/debuggui.cpp <span style="color:grey">(fb22bfb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117797/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div>
</div>
</blockquote></div><br><br clear="all"><br>-- <br>regards / pozdrawiam, Jaroslaw Staniek<br> Kexi & Calligra & KDE | <a href="http://calligra.org/kexi" target="_blank">http://calligra.org/kexi</a> | <a href="http://kde.org" target="_blank">http://kde.org</a><br>
Qt for Tizen | <a href="http://qt-project.org/wiki/Tizen" target="_blank">http://qt-project.org/wiki/Tizen</a><br> Qt Certified Specialist | <a href="http://www.linkedin.com/in/jstaniek" target="_blank">http://www.linkedin.com/in/jstaniek</a><br>
</div>