[calligra/calligra-qt5-rempt] sheets/part: comment out the loading of tools - or whatever this code does

Boudewijn Rempt boud at valdyas.org
Mon Sep 23 19:43:12 BST 2013


On Monday 23 September 2013 Sep 08:52:54 C.  Boemann wrote:
> Git commit 87ea1aba8b0308a5bb075867efedff3d71aecfb7 by C. Boemann.
> Committed on 23/09/2013 at 08:49.
> Pushed by boemann into branch 'calligra-qt5-rempt'.
> 
> comment out the loading of tools - or whatever this code does

It should load these plugins:

functions/kspreadbitopsmodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreadconversionmodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreaddatabasemodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreaddatetimemodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreadengineeringmodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreadfinancialmodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreadinformationmodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreadlogicmodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreadmathmodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreadreferencemodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreadstatisticalmodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreadtextmodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
functions/kspreadtrigonometrymodule.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo
plugins/calendar/kspread_plugin_tool_calendar.desktop:X-KDE-ServiceTypes=CalligraSheets/Plugin,KPluginInfo

However, in the Qt5 branch, this might have been changed by sebsauer.

> 
> it looks and feels completely useless - but should be reviewed
> 
> M  +2    -0    sheets/part/ToolRegistry.cpp
> 
> http://commits.kde.org/calligra/87ea1aba8b0308a5bb075867efedff3d71aecfb7
> 
> diff --git a/sheets/part/ToolRegistry.cpp b/sheets/part/ToolRegistry.cpp
> index 8f55ee1..03cb779 100644
> --- a/sheets/part/ToolRegistry.cpp
> +++ b/sheets/part/ToolRegistry.cpp
> @@ -59,6 +59,7 @@ ToolRegistry* ToolRegistry::instance()
>  
>  void ToolRegistry::loadTools()
>  {
> +#if 0
>      const QString serviceType = QLatin1String("CalligraSheets/Plugin");
>      const QString query = QLatin1String("([X-CalligraSheets-InterfaceVersion] == 0) and "
>                                          "([X-KDE-PluginInfo-Category] == 'Tool')");
> @@ -95,4 +96,5 @@ void ToolRegistry::loadTools()
>              KoToolRegistry::instance()->remove(toolFactory->id());
>          }
>      }
> +#endif
>  }
-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl




More information about the calligra-devel mailing list