[calligra/calligra-qt5-rempt] sheets/part: Comment out some code that doesn't seem to have any effect besides crashing sheets

[Boudewijn Rempt]

But _why_ does it crash? This code is indeed needed to load some Sheets plugins, and it's easy enough to find out which ones:

plugins/scripting/sheetsscripting.desktop:X-KDE-ServiceTypes=Sheets/ViewPlugin
plugins/solver/sheetssolver.desktop:X-KDE-ServiceTypes=Sheets/ViewPlugin
pivottables/sheetspivottables.desktop:X-KDE-ServiceTypes=Sheets/ViewPlugin


On Monday 23 September 2013 Sep 08:52:53 C.  Boemann wrote:
> Git commit fbca6b686e0f3115da2d46198925c6ba199f01e1 by C. Boemann.
> Committed on 23/09/2013 at 08:46.
> Pushed by boemann into branch 'calligra-qt5-rempt'.
> 
> Comment out some code that doesn't seem to have any effect besides crashing sheets
> 
> Note it might be used for some special plugins, so this commit should be reviewed later
> 
> M  +2    -2    sheets/part/View.cpp
> 
> http://commits.kde.org/calligra/fbca6b686e0f3115da2d46198925c6ba199f01e1
> 
> diff --git a/sheets/part/View.cpp b/sheets/part/View.cpp
> index 91ce28a..cef4ed2 100644
> --- a/sheets/part/View.cpp
> +++ b/sheets/part/View.cpp
> @@ -578,7 +578,7 @@ View::View(KoPart *part, QWidget *_parent, Doc *_doc)
>      initView();
>  
>      d->initActions();
> -
> +#if 0
>      KService::List offers = KServiceTypeTrader::self()->query(QString::fromLatin1("Sheets/ViewPlugin"),
>                                                                QString::fromLatin1("(Type == 'Service') and "
>                                                                                    "([X-Sheets-Version] == 28)"));
> @@ -599,7 +599,7 @@ View::View(KoPart *part, QWidget *_parent, Doc *_doc)
>              }
>          }
>      }
> -
> +#endif
>  
>      // Connect updateView() signal to View::update() in order to repaint its
>      // child widgets: the column/row headers and the select all button.
> 
-- 
Boudewijn Rempt
http://www.valdyas.org, http://www.krita.org, http://www.boudewijnrempt.nl