Review Request 112126: Remove warning about QVector resizing, optimize

Commit Hook null at kde.org
Fri Sep 6 23:24:36 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112126/
-----------------------------------------------------------

(Updated Sept. 6, 2013, 10:24 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Friedrich W. H. Kossebau, Marijn Kruisselbrink, Adam Pigg, and Tomasz Olszak.


Description
-------

Remove warning about QVector resizing, and optimize in one go. Previous code was suspicious to me...


Diffs
-----

  filters/sheets/excel/export/ExcelExport.cpp d73fa89870603ca710cc86ff6816db6e8247f72e 

Diff: http://git.reviewboard.kde.org/r/112126/diff/


Testing
-------

Behaviour is unchanged, still adds 10's until the size is sufficient.


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130906/7ad5ad33/attachment.htm>


More information about the calligra-devel mailing list