Review Request 112126: Remove warning about QVector resizing, optimize

Commit Hook null at kde.org
Fri Sep 6 23:24:30 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112126/#review39512
-----------------------------------------------------------


This review has been submitted with commit 16ea622867a93e04421e3f1aa90b90f89c5dac0d by Jaroslaw Staniek to branch calligra/2.7.

- Commit Hook


On Aug. 16, 2013, 8:17 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112126/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2013, 8:17 p.m.)
> 
> 
> Review request for Calligra, Friedrich W. H. Kossebau, Marijn Kruisselbrink, Adam Pigg, and Tomasz Olszak.
> 
> 
> Description
> -------
> 
> Remove warning about QVector resizing, and optimize in one go. Previous code was suspicious to me...
> 
> 
> Diffs
> -----
> 
>   filters/sheets/excel/export/ExcelExport.cpp d73fa89870603ca710cc86ff6816db6e8247f72e 
> 
> Diff: http://git.reviewboard.kde.org/r/112126/diff/
> 
> 
> Testing
> -------
> 
> Behaviour is unchanged, still adds 10's until the size is sufficient.
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130906/1bc17413/attachment.htm>


More information about the calligra-devel mailing list