Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111914/#review43233
-----------------------------------------------------------


I tested the patch with cstester and it looks quite ok. There is one problems however
- annotation shapes should not show in cstester or printing (I have a patch to fix that http://pastebin.kde.org/pb7rvurpn)
There is no possibility to switch of showing annotation shapes in stage :-(

Also I found a crash in the annotation shape.
To reproduce:
- Add a annotation shape
- Undo the adding (the shape is still shown)
- do some text editing
- Then add text to the annotation shape 
-> crash


- Thorsten Zachmann


On Nov. 6, 2013, 6:16 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111914/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 6:16 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch adds support for annotations to Words and Author. 
> 
> NOTE: We are aware that this patch is not yet ready for merge.  The review request is as much for ourselves (ingwa, moji, boemann) as for others.
> 
> The patch is large and rather complex so we use the review board to get an overview of the changes and to see early what we need to fix. There are still a number of bugs and not 100% of the features that we want to support are implemented.
> 
> All of this said, annotations basically work now and you can check out the branch text-annotation if you want to test it. We would like to get some feedback already now so we can fix the issues early and provide a cleaner patch once we have finished the feature completely.
> 
> 
> Diffs
> -----
> 
>   ANNOTATIONS-ODF PRE-CREATION 
>   TODO-ANNOTATIONS PRE-CREATION 
>   libs/flake/CMakeLists.txt 48274ce 
>   libs/flake/KoAnnotationLayoutManager.h PRE-CREATION 
>   libs/flake/KoAnnotationLayoutManager.cpp PRE-CREATION 
>   libs/flake/KoShapeController.h 2ae03ca 
>   libs/flake/KoShapeController.cpp 817ba5e 
>   libs/flake/KoShapeManager.h 9df1671 
>   libs/flake/KoShapeManager.cpp 36666ce 
>   libs/kotext/KoAnnotation.h c4457fd 
>   libs/kotext/KoAnnotation.cpp e5a8a53 
>   libs/kotext/KoTextEditor.h 9fd3c05 
>   libs/kotext/KoTextEditor.cpp 40ac427 
>   libs/kotext/KoTextRangeManager.cpp fdde8ee 
>   libs/kotext/opendocument/KoTextLoader.cpp 7831109 
>   libs/textlayout/KoTextDocumentLayout.h a0fabcf 
>   libs/textlayout/KoTextDocumentLayout.cpp 1eec452 
>   plugins/textshape/AnnotationTextShape.h PRE-CREATION 
>   plugins/textshape/AnnotationTextShape.cpp PRE-CREATION 
>   plugins/textshape/AnnotationTextShapeFactory.h PRE-CREATION 
>   plugins/textshape/AnnotationTextShapeFactory.cpp PRE-CREATION 
>   plugins/textshape/CMakeLists.txt 1838cf1 
>   plugins/textshape/ReviewTool.h e2b8f95 
>   plugins/textshape/ReviewTool.cpp 53c87c7 
>   plugins/textshape/SimpleRootAreaProvider.cpp 30a74ab 
>   plugins/textshape/TextPlugin.cpp b99243f 
>   plugins/textshape/TextTool.h d9b7e93 
>   plugins/textshape/TextTool.cpp 0ccb327 
>   plugins/textshape/TextToolFactory.cpp 0ced315 
>   plugins/textshape/dialogs/SimpleAnnotationWidget.h PRE-CREATION 
>   plugins/textshape/dialogs/SimpleAnnotationWidget.cpp PRE-CREATION 
>   plugins/textshape/dialogs/SimpleAnnotationWidget.ui PRE-CREATION 
>   words/part/KWCanvas.cpp f33d993 
>   words/part/KWCanvasBase.h 31111ce 
>   words/part/KWCanvasBase.cpp 22d1c5f 
>   words/part/KWDocument.h 0e012a7 
>   words/part/KWDocument.cpp 74a6ee8 
>   words/part/KWOdfSharedLoadingData.cpp 450b580 
>   words/part/KWOdfWriter.cpp 1675bf1 
>   words/part/KWView.h 466d0df 
>   words/part/KWView.cpp b299234 
>   words/part/KWViewModeNormal.cpp 88e67b2 
>   words/part/frames/KWTextFrameSet.cpp 1bb513c 
>   words/part/words.rc 7a26cb8 
> 
> Diff: http://git.reviewboard.kde.org/r/111914/diff/
> 
> 
> Testing
> -------
> 
> Created test files in LO with annotations and loaded them.  Also created our own test files.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131107/f8c60617/attachment.htm>