<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111914/">http://git.reviewboard.kde.org/r/111914/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested the patch with cstester and it looks quite ok. There is one problems however
- annotation shapes should not show in cstester or printing (I have a patch to fix that http://pastebin.kde.org/pb7rvurpn)
There is no possibility to switch of showing annotation shapes in stage :-(
Also I found a crash in the annotation shape.
To reproduce:
- Add a annotation shape
- Undo the adding (the shape is still shown)
- do some text editing
- Then add text to the annotation shape
-> crash
</pre>
<br />
<p>- Thorsten Zachmann</p>
<br />
<p>On November 6th, 2013, 6:16 p.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2013, 6:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for annotations to Words and Author.
NOTE: We are aware that this patch is not yet ready for merge. The review request is as much for ourselves (ingwa, moji, boemann) as for others.
The patch is large and rather complex so we use the review board to get an overview of the changes and to see early what we need to fix. There are still a number of bugs and not 100% of the features that we want to support are implemented.
All of this said, annotations basically work now and you can check out the branch text-annotation if you want to test it. We would like to get some feedback already now so we can fix the issues early and provide a cleaner patch once we have finished the feature completely.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created test files in LO with annotations and loaded them. Also created our own test files.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ANNOTATIONS-ODF <span style="color: grey">(PRE-CREATION)</span></li>
<li>TODO-ANNOTATIONS <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(48274ce)</span></li>
<li>libs/flake/KoAnnotationLayoutManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoAnnotationLayoutManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoShapeController.h <span style="color: grey">(2ae03ca)</span></li>
<li>libs/flake/KoShapeController.cpp <span style="color: grey">(817ba5e)</span></li>
<li>libs/flake/KoShapeManager.h <span style="color: grey">(9df1671)</span></li>
<li>libs/flake/KoShapeManager.cpp <span style="color: grey">(36666ce)</span></li>
<li>libs/kotext/KoAnnotation.h <span style="color: grey">(c4457fd)</span></li>
<li>libs/kotext/KoAnnotation.cpp <span style="color: grey">(e5a8a53)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(9fd3c05)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(40ac427)</span></li>
<li>libs/kotext/KoTextRangeManager.cpp <span style="color: grey">(fdde8ee)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: grey">(7831109)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.h <span style="color: grey">(a0fabcf)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.cpp <span style="color: grey">(1eec452)</span></li>
<li>plugins/textshape/AnnotationTextShape.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/AnnotationTextShape.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/AnnotationTextShapeFactory.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/AnnotationTextShapeFactory.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(1838cf1)</span></li>
<li>plugins/textshape/ReviewTool.h <span style="color: grey">(e2b8f95)</span></li>
<li>plugins/textshape/ReviewTool.cpp <span style="color: grey">(53c87c7)</span></li>
<li>plugins/textshape/SimpleRootAreaProvider.cpp <span style="color: grey">(30a74ab)</span></li>
<li>plugins/textshape/TextPlugin.cpp <span style="color: grey">(b99243f)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey">(d9b7e93)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(0ccb327)</span></li>
<li>plugins/textshape/TextToolFactory.cpp <span style="color: grey">(0ced315)</span></li>
<li>plugins/textshape/dialogs/SimpleAnnotationWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleAnnotationWidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleAnnotationWidget.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>words/part/KWCanvas.cpp <span style="color: grey">(f33d993)</span></li>
<li>words/part/KWCanvasBase.h <span style="color: grey">(31111ce)</span></li>
<li>words/part/KWCanvasBase.cpp <span style="color: grey">(22d1c5f)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(0e012a7)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(74a6ee8)</span></li>
<li>words/part/KWOdfSharedLoadingData.cpp <span style="color: grey">(450b580)</span></li>
<li>words/part/KWOdfWriter.cpp <span style="color: grey">(1675bf1)</span></li>
<li>words/part/KWView.h <span style="color: grey">(466d0df)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(b299234)</span></li>
<li>words/part/KWViewModeNormal.cpp <span style="color: grey">(88e67b2)</span></li>
<li>words/part/frames/KWTextFrameSet.cpp <span style="color: grey">(1bb513c)</span></li>
<li>words/part/words.rc <span style="color: grey">(7a26cb8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111914/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>