Review Request 113261: Port KoRdfFoaF & KoRdfCalendarEvent to Akonadi

Commit Hook null at kde.org
Sun Nov 3 21:30:27 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113261/#review42911
-----------------------------------------------------------


This review has been submitted with commit 969ed0995393bf31a7e19e0036e690eca85dbfa8 by Friedrich W. H. Kossebau to branch master.

- Commit Hook


On Nov. 3, 2013, 9:20 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113261/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2013, 9:20 p.m.)
> 
> 
> Review request for Calligra, C. Boemann and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Time to get rid of those mass "Deprecated!!11!" warnings finally, no? :)
> 
> Instead of saving to some default addressbook/calendar queries the user where to save to. Simplest solution, as with Akonadi there is no such concept as a default addressbook/calendar. And this is prototype code anyway.
> 
> Also sets the minimal KDEPIM wanted to 4.6, as that only brings KCalCore in and I did not feel like if-def-ing KoRdfCalendarEvent.
> KDEPIM >= 4.6 might not be on CentOO 6, but Plan needs newer Akonadi classes (4.5) for some time/releases already (without telling), so pushing the min. req. directly to 4.6.0 seemed okay to me.
> 
> Which means no KDEPIM export support for those RDF classes on CentOS 6 in the next release, but that should be okay, or is anybody known to need it there?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4336d86 
>   README.PACKAGERS e82029c 
>   plugins/semanticitems/contact/CMakeLists.txt ad9fcab 
>   plugins/semanticitems/contact/KoRdfFoaF.h 64317c7 
>   plugins/semanticitems/contact/KoRdfFoaF.cpp 8344136 
>   plugins/semanticitems/event/CMakeLists.txt 4222655 
>   plugins/semanticitems/event/KoRdfCalendarEvent.h 351820c 
>   plugins/semanticitems/event/KoRdfCalendarEvent.cpp 9763abe 
> 
> Diff: http://git.reviewboard.kde.org/r/113261/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20131103/61381f25/attachment.htm>


More information about the calligra-devel mailing list