<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113261/">http://git.reviewboard.kde.org/r/113261/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 969ed0995393bf31a7e19e0036e690eca85dbfa8 by Friedrich W. H. Kossebau to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On November 3rd, 2013, 9:20 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra, C. Boemann and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2013, 9:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Time to get rid of those mass "Deprecated!!11!" warnings finally, no? :)
Instead of saving to some default addressbook/calendar queries the user where to save to. Simplest solution, as with Akonadi there is no such concept as a default addressbook/calendar. And this is prototype code anyway.
Also sets the minimal KDEPIM wanted to 4.6, as that only brings KCalCore in and I did not feel like if-def-ing KoRdfCalendarEvent.
KDEPIM >= 4.6 might not be on CentOO 6, but Plan needs newer Akonadi classes (4.5) for some time/releases already (without telling), so pushing the min. req. directly to 4.6.0 seemed okay to me.
Which means no KDEPIM export support for those RDF classes on CentOS 6 in the next release, but that should be okay, or is anybody known to need it there?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4336d86)</span></li>
<li>README.PACKAGERS <span style="color: grey">(e82029c)</span></li>
<li>plugins/semanticitems/contact/CMakeLists.txt <span style="color: grey">(ad9fcab)</span></li>
<li>plugins/semanticitems/contact/KoRdfFoaF.h <span style="color: grey">(64317c7)</span></li>
<li>plugins/semanticitems/contact/KoRdfFoaF.cpp <span style="color: grey">(8344136)</span></li>
<li>plugins/semanticitems/event/CMakeLists.txt <span style="color: grey">(4222655)</span></li>
<li>plugins/semanticitems/event/KoRdfCalendarEvent.h <span style="color: grey">(351820c)</span></li>
<li>plugins/semanticitems/event/KoRdfCalendarEvent.cpp <span style="color: grey">(9763abe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113261/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>