Review Request 110507: Create a second ODF library for classes not used in any application

Sun May 19 05:30:47 BST 2013

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110507/#review32765
-----------------------------------------------------------

Besides of the small comments I think it looks good. However I would have used a different name for the lib e.g. odffilter instead of odf2. For me odf2 sounds like it is a second gneration lib that would like to replace odf at one point.

filters/libodf2/KoCellStyle.h
<http://git.reviewboard.kde.org/r/110507/#comment24336>

    The include should use <> instead of "" as it is no longer in the same directory

filters/libodf2/KoCellStyle.cpp
<http://git.reviewboard.kde.org/r/110507/#comment24337>

    The includes should use <> as the files are no longer in the same directory.

filters/libodf2/KoColumnStyle.cpp
<http://git.reviewboard.kde.org/r/110507/#comment24338>

    The includes should use <> as the file is no longer in the same directory.

filters/libodf2/KoRawCellChild.h
<http://git.reviewboard.kde.org/r/110507/#comment24339>

    Should that not use a QByteArray include instead of QBuffer?

filters/libodf2/KoStyle.h
<http://git.reviewboard.kde.org/r/110507/#comment24340>

    The includes should use <> as the files are no longer in the same directory.

filters/libodf2/KoStyle.cpp
<http://git.reviewboard.kde.org/r/110507/#comment24341>

    The includes should use <> as the file is no longer in the same directory.

- Thorsten Zachmann

On May 18, 2013, 3:25 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110507/
> -----------------------------------------------------------
> 
> (Updated May 18, 2013, 3:25 p.m.)
> 
> 
> Review request for Calligra and Thorsten Zachmann.
> 
> 
> Description
> -------
> 
> This patch moves a number of classes from libs/odf to a new library: filters/odf2.
> 
> The classes are some of the ones which are discussed in the mail thread about the scope of libs/odf. There are no code changes except for the obvious (including koodf2_export.h for instance).
> 
> The classes in libs/odf/styles/ will be moved in my branch because I think i will get too many conflicts in my other branch if I do that here.
> 
> 
> Diffs
> -----
> 
>   filters/libodf2/KoTblStyle.h PRE-CREATION 
>   filters/libodf2/KoTblStyle.cpp PRE-CREATION 
>   filters/libodf2/README PRE-CREATION 
>   filters/libodf2/koodf2_export.h PRE-CREATION 
>   filters/stage/pptx/CMakeLists.txt 10fc7c5 
>   filters/libodf2/KoTable.h PRE-CREATION 
>   filters/libodf2/KoTable.cpp PRE-CREATION 
>   filters/libodf2/KoStyle.cpp PRE-CREATION 
>   filters/libodf2/KoRowStyle.cpp PRE-CREATION 
>   filters/libodf2/KoStyle.h PRE-CREATION 
>   filters/libodf2/KoRow.cpp PRE-CREATION 
>   filters/libodf2/KoRowStyle.h PRE-CREATION 
>   filters/libodf2/KoRow.h PRE-CREATION 
>   filters/libodf2/KoRawCellChild.h PRE-CREATION 
>   filters/libodf2/KoRawCellChild.cpp PRE-CREATION 
>   filters/libodf2/KoDummyCellValue.cpp PRE-CREATION 
>   filters/libodf2/KoColumnStyle.cpp PRE-CREATION 
>   filters/libodf2/KoDummyCellValue.h PRE-CREATION 
>   filters/libodf2/KoColumnStyle.h PRE-CREATION 
>   filters/libodf2/KoColumn.h PRE-CREATION 
>   filters/libodf2/KoColumn.cpp PRE-CREATION 
>   filters/libodf2/KoCellValue.h PRE-CREATION 
>   filters/libodf2/KoCellValue.cpp PRE-CREATION 
>   filters/libodf2/KoCellStyle.cpp PRE-CREATION 
>   filters/libodf2/KoCellChild.cpp PRE-CREATION 
>   filters/libodf2/KoCellStyle.h PRE-CREATION 
>   filters/libodf2/KoCell.cpp PRE-CREATION 
>   filters/libodf2/KoCellChild.h PRE-CREATION 
>   filters/libodf2/KoCell.h PRE-CREATION 
>   filters/libmsooxml/CMakeLists.txt fdbb8a9 
>   filters/libodf2/CMakeLists.txt PRE-CREATION 
>   CMakeLists.txt f03ebae 
>   filters/CMakeLists.txt 6756c6c 
>   filters/words/docx/import/CMakeLists.txt e8a3f50 
>   libs/odf/CMakeLists.txt b3940c1 
>   libs/odf/KoCell.h 298eeda 
>   libs/odf/KoCell.cpp e22c663 
>   libs/odf/KoCellChild.h d4e042b 
>   libs/odf/KoCellChild.cpp ae33421 
>   libs/odf/KoCellStyle.h 5f3fc06 
>   libs/odf/KoCellStyle.cpp 17bf3d0 
>   libs/odf/KoCellValue.h 9735ff6 
>   libs/odf/KoCellValue.cpp f9b77c1 
>   libs/odf/KoColumn.h 56549ba 
>   libs/odf/KoColumn.cpp 0158906 
>   libs/odf/KoColumnStyle.h de38508 
>   libs/odf/KoColumnStyle.cpp e5c3e0d 
>   libs/odf/KoDummyCellValue.h 2fb3ff9 
>   libs/odf/KoDummyCellValue.cpp 1db80b8 
>   libs/odf/KoRawCellChild.h d996c12 
>   libs/odf/KoRawCellChild.cpp 39ed998 
>   libs/odf/KoRow.h 4aa7927 
>   libs/odf/KoRow.cpp cc20d91 
>   libs/odf/KoRowStyle.h 44f9cac 
>   libs/odf/KoRowStyle.cpp cece778 
>   libs/odf/KoStyle.h ecfeaa6 
>   libs/odf/KoStyle.cpp cd1242e 
>   libs/odf/KoTable.h 95474de 
>   libs/odf/KoTable.cpp f0f8b18 
>   libs/odf/KoTblStyle.h d5ec4d3 
>   libs/odf/KoTblStyle.cpp 4c34251 
> 
> Diff: http://git.reviewboard.kde.org/r/110507/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130519/e75c45a8/attachment.htm>