<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110507/">http://git.reviewboard.kde.org/r/110507/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Besides of the small comments I think it looks good. However I would have used a different name for the lib e.g. odffilter instead of odf2. For me odf2 sounds like it is a second gneration lib that would like to replace odf at one point.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110507/diff/1/?file=144938#file144938line23" style="color: black; font-weight: bold; text-decoration: underline;">filters/libodf2/KoCellStyle.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "KoBorder.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The include should use <> instead of "" as it is no longer in the same directory</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110507/diff/1/?file=144939#file144939line20" style="color: black; font-weight: bold; text-decoration: underline;">filters/libodf2/KoCellStyle.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "KoGenStyle.h"</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "KoGenStyles.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The includes should use <> as the files are no longer in the same directory.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110507/diff/1/?file=144945#file144945line20" style="color: black; font-weight: bold; text-decoration: underline;">filters/libodf2/KoColumnStyle.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "KoGenStyle.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The includes should use <> as the file is no longer in the same directory.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110507/diff/1/?file=144948#file144948line25" style="color: black; font-weight: bold; text-decoration: underline;">filters/libodf2/KoRawCellChild.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include <QBuffer></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should that not use a QByteArray include instead of QBuffer?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110507/diff/1/?file=144954#file144954line25" style="color: black; font-weight: bold; text-decoration: underline;">filters/libodf2/KoStyle.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "KoGenStyles.h"</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">26</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "KoGenStyle.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The includes should use <> as the files are no longer in the same directory.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110507/diff/1/?file=144955#file144955line20" style="color: black; font-weight: bold; text-decoration: underline;">filters/libodf2/KoStyle.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "KoGenStyles.h"</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The includes should use <> as the file is no longer in the same directory.</pre>
</div>
<br />
<p>- Thorsten</p>
<br />
<p>On May 18th, 2013, 3:25 p.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Calligra and Thorsten Zachmann.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated May 18, 2013, 3:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch moves a number of classes from libs/odf to a new library: filters/odf2.
The classes are some of the ones which are discussed in the mail thread about the scope of libs/odf. There are no code changes except for the obvious (including koodf2_export.h for instance).
The classes in libs/odf/styles/ will be moved in my branch because I think i will get too many conflicts in my other branch if I do that here.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/libodf2/KoTblStyle.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoTblStyle.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/koodf2_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/stage/pptx/CMakeLists.txt <span style="color: grey">(10fc7c5)</span></li>
<li>filters/libodf2/KoTable.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoTable.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoStyle.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoRowStyle.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoStyle.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoRow.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoRowStyle.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoRow.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoRawCellChild.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoRawCellChild.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoDummyCellValue.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoColumnStyle.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoDummyCellValue.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoColumnStyle.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoColumn.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoColumn.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoCellValue.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoCellValue.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoCellStyle.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoCellChild.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoCellStyle.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoCell.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoCellChild.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libodf2/KoCell.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>filters/libmsooxml/CMakeLists.txt <span style="color: grey">(fdbb8a9)</span></li>
<li>filters/libodf2/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(f03ebae)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(6756c6c)</span></li>
<li>filters/words/docx/import/CMakeLists.txt <span style="color: grey">(e8a3f50)</span></li>
<li>libs/odf/CMakeLists.txt <span style="color: grey">(b3940c1)</span></li>
<li>libs/odf/KoCell.h <span style="color: grey">(298eeda)</span></li>
<li>libs/odf/KoCell.cpp <span style="color: grey">(e22c663)</span></li>
<li>libs/odf/KoCellChild.h <span style="color: grey">(d4e042b)</span></li>
<li>libs/odf/KoCellChild.cpp <span style="color: grey">(ae33421)</span></li>
<li>libs/odf/KoCellStyle.h <span style="color: grey">(5f3fc06)</span></li>
<li>libs/odf/KoCellStyle.cpp <span style="color: grey">(17bf3d0)</span></li>
<li>libs/odf/KoCellValue.h <span style="color: grey">(9735ff6)</span></li>
<li>libs/odf/KoCellValue.cpp <span style="color: grey">(f9b77c1)</span></li>
<li>libs/odf/KoColumn.h <span style="color: grey">(56549ba)</span></li>
<li>libs/odf/KoColumn.cpp <span style="color: grey">(0158906)</span></li>
<li>libs/odf/KoColumnStyle.h <span style="color: grey">(de38508)</span></li>
<li>libs/odf/KoColumnStyle.cpp <span style="color: grey">(e5c3e0d)</span></li>
<li>libs/odf/KoDummyCellValue.h <span style="color: grey">(2fb3ff9)</span></li>
<li>libs/odf/KoDummyCellValue.cpp <span style="color: grey">(1db80b8)</span></li>
<li>libs/odf/KoRawCellChild.h <span style="color: grey">(d996c12)</span></li>
<li>libs/odf/KoRawCellChild.cpp <span style="color: grey">(39ed998)</span></li>
<li>libs/odf/KoRow.h <span style="color: grey">(4aa7927)</span></li>
<li>libs/odf/KoRow.cpp <span style="color: grey">(cc20d91)</span></li>
<li>libs/odf/KoRowStyle.h <span style="color: grey">(44f9cac)</span></li>
<li>libs/odf/KoRowStyle.cpp <span style="color: grey">(cece778)</span></li>
<li>libs/odf/KoStyle.h <span style="color: grey">(ecfeaa6)</span></li>
<li>libs/odf/KoStyle.cpp <span style="color: grey">(cd1242e)</span></li>
<li>libs/odf/KoTable.h <span style="color: grey">(95474de)</span></li>
<li>libs/odf/KoTable.cpp <span style="color: grey">(f0f8b18)</span></li>
<li>libs/odf/KoTblStyle.h <span style="color: grey">(d5ec4d3)</span></li>
<li>libs/odf/KoTblStyle.cpp <span style="color: grey">(4c34251)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110507/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>