Review Request 110383: Implement Distraction-Free mode for Words and Author.
C. Boemann
cbr at boemann.dk
Sat May 11 06:12:43 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110383/#review32344
-----------------------------------------------------------
Ship it!
I'm just going t take your words for it. I semi reviewed every commit on the way so I'm okay with it going in.
But the license is a deal breaker for sure
And when it does go in can I ask it be committed to master in two parts.
1 ) the stuff in libs and krita
2 ) the stuff in words
and in that order naturally due to dependency
- C. Boemann
On May 10, 2013, 5:54 p.m., mojtaba shahi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110383/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 5:54 p.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Implement Distraction-Free mode for Words and Author.
> Added an action "View->Distractio Free Mode". This action Hide Menu bar, Tool bar, Staus bar, Dock widgets ,Vertical and horizontl scroll bar from view.
> When you switch to Distractio-Free mode it will rise a floating message say how can you get out from this view.
> I have added a "Exit Distractio-Free Mode" button to status bar that user can get back to normal view by clicking ont it. (it is visible just in DF mode)
> Staus bar will show if user moves mouse on status bar at bottom.
> Horizontal and Vertical scroll bars will show when user moves mouse on them.
> Cursor will Hide, user doesn't move mouse after 4 seconds.
>
>
> Diffs
> -----
>
> krita/plugins/tools/tool_crop/kis_tool_crop.cc 05e905b
> krita/ui/CMakeLists.txt 37e4635
> krita/ui/kis_view2.cpp 7d4c6da
> krita/ui/tool/kis_tool.cc 33dbbf0
> krita/ui/widgets/kis_floating_message.h 0d42e8b
> krita/ui/widgets/kis_floating_message.cpp d53e133
> libs/main/KoMainWindow.cpp ea45075
> libs/main/KoView.cpp c9c82e5
> libs/widgets/CMakeLists.txt 4e6e362
> libs/widgets/KoFloatingMessage.h PRE-CREATION
> libs/widgets/KoFloatingMessage.cpp PRE-CREATION
> words/part/KWCanvas.cpp 4252ff7
> words/part/KWGui.h c72234d
> words/part/KWGui.cpp 803e1b5
> words/part/KWView.h 6357876
> words/part/KWView.cpp 5c1cc70
> words/part/author/author.rc b3b187c
> words/part/words.rc d2269d1
>
> Diff: http://git.reviewboard.kde.org/r/110383/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> Distraction-Free Mode
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_1.png
> Distraction-Free mode with Status bar
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_2.png
> Distraction-Free mode with vertical scroll bar
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_3.png
>
>
> Thanks,
>
> mojtaba shahi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20130511/f3ca6265/attachment.htm>
More information about the calligra-devel
mailing list